public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: syyang@lontium.com, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, andrzej.hajda@intel.com,
	neil.armstrong@linaro.org, dmitry.baryshkov@oss.qualcomm.com,
	maarten.lankhorst@linux.intel.com, rfoss@kernel.org,
	mripard@kernel.org
Cc: Laurent.pinchart@ideasonboard.com, tzimmermann@ideasonboard.com,
	jonas@kwiboo.se, jernej.skrabec@gmail.com,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, yangsunyun1993@gmail.com,
	xmzhu@lontium.corp-partner.google.com
Subject: Re: [PATCH v3 1/2] dt-bindings: bridge: This patch adds new content to the lontium,lt9611.yaml binding file
Date: Mon, 20 Apr 2026 16:15:27 +0200	[thread overview]
Message-ID: <20260420-sophisticated-scorpion-from-camelot-b9f326@quoll> (raw)
In-Reply-To: <192f1948-bb9a-4831-a1cd-5ef500cfb413@kernel.org>

On Mon, Apr 20, 2026 at 01:33:46PM +0200, Krzysztof Kozlowski wrote:
> > -audio
> >  1.sample rates of 32~192 KHz and sample sizes
> >    of 16~24 bits
> >  2.SPDIF interface supports PCM, Dolbydigital, DTS digital audio
> >    at up to 192KHz frame rate
> > 
> > -Miscellaneous
> >  1.CSC:RGB<->YUV444<->YUV422
> 
> Commit msg is not a datasheet introduction chapter. What does this all
> mean for compatibility? What is the benefit of listing all this?
> 
> You did not even explain the differences between C, UX and EXD, so all
> above is pointless. Explain the differences and why devices are not
> compatible.
>

Also, you have checkpatch errors.

Best regards,
Krzysztof


  reply	other threads:[~2026-04-20 14:15 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20  6:16 [PATCH v3 0/2] Add LT9611C(EX/UXD) DRM bridge driver and device tree syyang
2026-04-20  6:16 ` [PATCH v3 1/2] dt-bindings: bridge: This patch adds new content to the lontium, lt9611.yaml binding file syyang
2026-04-20 11:33   ` [PATCH v3 1/2] dt-bindings: bridge: This patch adds new content to the lontium,lt9611.yaml " Krzysztof Kozlowski
2026-04-20 14:15     ` Krzysztof Kozlowski [this message]
2026-04-20 14:18       ` Krzysztof Kozlowski
2026-04-21  3:39         ` 杨孙运
2026-04-23  0:19     ` Claude review: " Claude Code Review Bot
2026-04-20  6:16 ` [PATCH v3 2/2] drm/bridge: This patch add new DRM bridge driver for LT9611C(EX/UXD) chip syyang
2026-04-20 12:18   ` Dmitry Baryshkov
2026-04-21  7:37     ` 杨孙运
2026-04-21 10:48       ` Dmitry Baryshkov
2026-04-22  4:41         ` 杨孙运
2026-04-22 18:56           ` Dmitry Baryshkov
2026-04-23  0:19     ` Claude review: " Claude Code Review Bot
2026-04-20 10:45 ` [PATCH v3 0/2] Add LT9611C(EX/UXD) DRM bridge driver and device tree Dmitry Baryshkov
2026-04-20 11:05   ` 杨孙运
2026-04-21 10:49     ` Dmitry Baryshkov
2026-04-23  0:19   ` Claude review: " Claude Code Review Bot
2026-04-21  5:09 ` Jingyi Wang
2026-04-21  5:49   ` 杨孙运

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260420-sophisticated-scorpion-from-camelot-b9f326@quoll \
    --to=krzk@kernel.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=andrzej.hajda@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=syyang@lontium.com \
    --cc=tzimmermann@ideasonboard.com \
    --cc=xmzhu@lontium.corp-partner.google.com \
    --cc=yangsunyun1993@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox