Claude review: Re: [PATCH v3 0/2] Add LT9611C(EX/UXD) DRM bridge driver and device tree

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Re: [PATCH v3 0/2] Add LT9611C(EX/UXD) DRM bridge driver and device tree
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 17
Reviewed: 2026-04-23T10:19:49.194403

---

This series adds a DRM bridge driver for the Lontium LT9611C/EX/UXD MIPI DSI-to-HDMI converter chips, along with a dt-bindings update. The driver uses an interesting architecture where commands are sent to an on-chip MCU via a read/write flow protocol rather than directly programming hardware registers. The v3 changelog shows good progress incorporating review feedback (using `devm_drm_bridge_alloc`, HDMI audio helpers, CRC8 library, etc.).

However, there are several significant issues that need to be addressed before this can be merged:

1. **Missing `DRM_BRIDGE_OP_HDMI` flag** — The driver implements AVI, HDMI, and SPD infoframe callbacks but does not set `DRM_BRIDGE_OP_HDMI` (or `DRM_BRIDGE_OP_HDMI_SPD_INFOFRAME`) in `bridge.ops`. Without these flags, the framework will never call those callbacks. The existing lt9611 driver sets these correctly. This also means `vendor`, `product`, `supported_formats`, and `max_bpc` must be set on the bridge.
2. **Buffer overflow in infoframe write functions** — The infoframe callbacks copy `len` bytes from `buffer` into a fixed 16-byte command array without bounds checking. An infoframe can be up to ~31 bytes, overflowing the stack buffer.
3. **Improper error returns** — Several functions return magic values like `-1` or `-2` instead of proper errno codes.
4. **dt-bindings patch uses fullwidth punctuation** and has formatting issues.
5. **`SET_SYSTEM_SLEEP_PM_OPS` is deprecated** — should use `DEFINE_SIMPLE_DEV_PM_OPS`.
6. **Missing `atomic_duplicate_state`/`atomic_reset`** bridge callbacks.
7. **Sysfs firmware upgrade interface** is unusual and needs better justification.

---

---
Generated by Claude Code Patch Reviewer