From: Brady Norander <brady.norander@mainlining.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Brady Norander <brady.norander@mainlining.org>
Subject: [PATCH] drm/panel/boe-tv101wum-nl6: set MIPI_DSI_MODE_LPM after sending panel disable cmds
Date: Tue, 21 Apr 2026 11:31:48 -0400 [thread overview]
Message-ID: <20260421153147.4378-2-brady.norander@mainlining.org> (raw)
A recent change to Mediatek drm driver enabled HS mode support. With that
change, my MT8183-based krane sku176 chromebook display's colors would look darker
and desaturated after turning the display off and back on. Looking at other panel
drivers, it seems common to enable HS mode to send the disable commands and to
disable HS mode afterwards. However, the boe-tv101wum-nl6 driver would never
disable HS mode, leading to this issue. Update the behavior of boe_panel_disable
to match those other panel drivers. As a side note, I did also test removing the
line which enables HS mode during panel_disable. This worked fine for my device,
but just in case that doesn't work for other devices, I chose to keep that and
instead disable HS mode after sending the panel disable commands.
Signed-off-by: Brady Norander <brady.norander@mainlining.org>
diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
index d5fe105bdbdd..f69b5bd776c0 100644
--- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
+++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
@@ -1326,6 +1326,8 @@ static int boe_panel_disable(struct drm_panel *panel)
mipi_dsi_msleep(&ctx, 150);
+ boe->dsi->mode_flags |= MIPI_DSI_MODE_LPM;
+
return ctx.accum_err;
}
--
2.52.0
next reply other threads:[~2026-04-22 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 15:31 Brady Norander [this message]
2026-04-22 22:22 ` Claude review: drm/panel/boe-tv101wum-nl6: set MIPI_DSI_MODE_LPM after sending panel disable cmds Claude Code Review Bot
2026-04-22 22:22 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260421153147.4378-2-brady.norander@mainlining.org \
--to=brady.norander@mainlining.org \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox