public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel/boe-tv101wum-nl6: set MIPI_DSI_MODE_LPM after sending panel disable cmds
Date: Thu, 23 Apr 2026 08:22:29 +1000	[thread overview]
Message-ID: <review-overall-20260421153147.4378-2-brady.norander@mainlining.org> (raw)
In-Reply-To: <20260421153147.4378-2-brady.norander@mainlining.org>

Overall Series Review

Subject: drm/panel/boe-tv101wum-nl6: set MIPI_DSI_MODE_LPM after sending panel disable cmds
Author: Brady Norander <brady.norander@mainlining.org>
Patches: 1
Reviewed: 2026-04-23T08:22:29.769041

---

This is a single-patch fix for a real visual regression on MT8183 krane Chromebook hardware. The commit message clearly explains the root cause: a recent Mediatek DRM change enabled HS mode support, and the boe-tv101wum-nl6 panel driver was clearing `MIPI_DSI_MODE_LPM` in `boe_panel_disable()` to send disable commands in HS mode but never restoring it. This left the DSI link in HS mode permanently after the first disable cycle, causing color issues on subsequent enable.

The fix is minimal, correct, and follows established patterns in other panel drivers. The code change is a single line addition that restores `MIPI_DSI_MODE_LPM` after the disable commands have been sent and the sleep delay has elapsed. This is a clean, low-risk bugfix.

**Verdict: Looks good. This should be straightforward to accept.**

One minor nit: the patch lacks a `Fixes:` tag. It would be helpful to include one referencing the Mediatek DRM commit that exposed this issue, or at least the original commit that introduced the asymmetric LPM clearing in `boe_panel_disable()`. This would help stable backport triage.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-22 22:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-21 15:31 [PATCH] drm/panel/boe-tv101wum-nl6: set MIPI_DSI_MODE_LPM after sending panel disable cmds Brady Norander
2026-04-22 22:22 ` Claude Code Review Bot [this message]
2026-04-22 22:22 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260421153147.4378-2-brady.norander@mainlining.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox