public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: misc: qcom,fastrpc: Add compatible for Hawi SoC
@ 2026-04-27 19:09 Mukesh Ojha
  2026-04-28  3:59 ` Claude review: " Claude Code Review Bot
  2026-04-28  3:59 ` Claude Code Review Bot
  0 siblings, 2 replies; 3+ messages in thread
From: Mukesh Ojha @ 2026-04-27 19:09 UTC (permalink / raw)
  To: Srinivas Kandagatla, Amol Maheshwari, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: linux-arm-msm, dri-devel, devicetree, linux-kernel, Mukesh Ojha

Document compatible for Qualcomm Hawi fastrpc which is fully
compatible with Qualcomm Kaanapali fastrpc.

Signed-off-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
index ca830dd06de2..2876fdd7c6e6 100644
--- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
+++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
@@ -25,6 +25,7 @@ properties:
       - items:
           - enum:
               - qcom,glymur-fastrpc
+              - qcom,hawi-fastrpc
           - const: qcom,kaanapali-fastrpc
 
   label:
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Claude review: dt-bindings: misc: qcom,fastrpc: Add compatible for Hawi SoC
  2026-04-27 19:09 [PATCH] dt-bindings: misc: qcom,fastrpc: Add compatible for Hawi SoC Mukesh Ojha
@ 2026-04-28  3:59 ` Claude Code Review Bot
  2026-04-28  3:59 ` Claude Code Review Bot
  1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-04-28  3:59 UTC (permalink / raw)
  To: dri-devel-reviews

Overall Series Review

Subject: dt-bindings: misc: qcom,fastrpc: Add compatible for Hawi SoC
Author: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Patches: 1
Reviewed: 2026-04-28T13:59:20.904069

---

This is a trivial, straightforward single-patch addition of a new SoC compatible string to an existing dt-binding. The patch adds `qcom,hawi-fastrpc` as a new compatible that falls back to `qcom,kaanapali-fastrpc`, following the exact same pattern already established by `qcom,glymur-fastrpc`. No issues found.

**Verdict: Looks good.**

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Claude review: dt-bindings: misc: qcom,fastrpc: Add compatible for Hawi SoC
  2026-04-27 19:09 [PATCH] dt-bindings: misc: qcom,fastrpc: Add compatible for Hawi SoC Mukesh Ojha
  2026-04-28  3:59 ` Claude review: " Claude Code Review Bot
@ 2026-04-28  3:59 ` Claude Code Review Bot
  1 sibling, 0 replies; 3+ messages in thread
From: Claude Code Review Bot @ 2026-04-28  3:59 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

**Commit message:** Clear and adequate. States that Hawi fastrpc is "fully compatible with Qualcomm Kaanapali fastrpc," which correctly explains why it's added as a fallback entry under the `qcom,kaanapali-fastrpc` const.

**Code change:**

```yaml
      - items:
          - enum:
              - qcom,glymur-fastrpc
+              - qcom,hawi-fastrpc
          - const: qcom,kaanapali-fastrpc
```

The new entry is inserted in alphabetical order within the enum list, which is correct dt-binding convention. The schema structure is preserved — `qcom,hawi-fastrpc` paired with the `qcom,kaanapali-fastrpc` fallback is the standard two-element compatible pattern for SoC-specific variants that are compatible with an existing SoC's implementation.

**One minor observation:** There is no corresponding driver-side change to add `qcom,hawi-fastrpc` to a `of_device_id` table. This is fine if the driver already matches on the fallback `qcom,kaanapali-fastrpc` compatible (which is the intent of the two-entry compatible list), but the submitter should confirm the driver does match on the fallback. This is standard practice for dt-binding-only patches and not a blocking concern.

**No issues.** Reviewed-by worthy as-is.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-04-28  3:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-27 19:09 [PATCH] dt-bindings: misc: qcom,fastrpc: Add compatible for Hawi SoC Mukesh Ojha
2026-04-28  3:59 ` Claude review: " Claude Code Review Bot
2026-04-28  3:59 ` Claude Code Review Bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox