From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: Harry Wentland <harry.wentland@amd.com>,
Leo Li <sunpeng.li@amd.com>,
Rodrigo Siqueira <siqueira@igalia.com>,
Alex Deucher <alexander.deucher@amd.com>,
Christian König <christian.koenig@amd.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Sandy Huang <hjc@rock-chips.com>, Heiko Stübner <heiko@sntech.de>,
Andy Yan <andy.yan@rock-chips.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Dmitry Baryshkov <lumag@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Rob Herring <robh@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Daniel Stone <daniel@fooishbar.org>
Cc: kernel@collabora.com, amd-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
linux-doc@vger.kernel.org, wayland-devel@lists.freedesktop.org,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Subject: [PATCH v15 12/28] drm/i915/dp: Add YCBCR444 handling for sink formats
Date: Fri, 22 May 2026 14:32:03 +0200 [thread overview]
Message-ID: <20260522-color-format-v15-12-21fb136c9df2@collabora.com> (raw)
In-Reply-To: <20260522-color-format-v15-0-21fb136c9df2@collabora.com>
In anticipation of userspace being able to explicitly select supported
sink formats, add handling of the YCBCR444 sink format. The AUTO path
does not choose this format, but with explicit format selection added to
the driver, it becomes a possibility.
Check for both source and sink support of YCBCR444 in
intel_dp_sink_format_valid.
Acked-by: Daniel Stone <daniel@fooishbar.org>
Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 1920d2f02666..143ed85224be 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -1344,6 +1344,20 @@ intel_dp_mode_valid_downstream(struct intel_connector *connector,
8, sink_format, true);
}
+static bool
+intel_dp_can_ycbcr444(struct intel_dp *intel_dp)
+{
+ if (source_can_output(intel_dp, INTEL_OUTPUT_FORMAT_YCBCR444) &&
+ !drm_dp_is_branch(intel_dp->dpcd))
+ return true;
+
+ if (source_can_output(intel_dp, INTEL_OUTPUT_FORMAT_RGB) &&
+ dfp_can_convert_from_rgb(intel_dp, INTEL_OUTPUT_FORMAT_YCBCR444))
+ return true;
+
+ return false;
+}
+
static enum drm_mode_status
intel_dp_sink_format_valid(struct intel_connector *connector,
const struct drm_display_mode *mode,
@@ -1364,6 +1378,13 @@ intel_dp_sink_format_valid(struct intel_connector *connector,
return MODE_OK;
case INTEL_OUTPUT_FORMAT_RGB:
+ return MODE_OK;
+ case INTEL_OUTPUT_FORMAT_YCBCR444:
+ if (!(info->color_formats & BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR444)))
+ return MODE_BAD;
+ if (!intel_dp_can_ycbcr444(intel_dp))
+ return MODE_BAD;
+
return MODE_OK;
default:
MISSING_CASE(sink_format);
--
2.54.0
next prev parent reply other threads:[~2026-05-22 12:34 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 12:31 [PATCH v15 00/28] Add new general DRM property "color format" Nicolas Frattaroli
2026-05-22 12:31 ` [PATCH v15 01/28] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:31 ` [PATCH v15 02/28] drm/display: hdmi-state-helper: Use default case for unsupported formats Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:31 ` [PATCH v15 03/28] drm: Add new general DRM property "color format" Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:31 ` [PATCH v15 04/28] drm/connector: Let connectors have a say in their color format Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:31 ` [PATCH v15 05/28] drm/display: bridge_connector: Use HDMI color format for HDMI conns Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:31 ` [PATCH v15 06/28] drm/bridge: Act on the DRM color format property Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:31 ` [PATCH v15 07/28] drm/atomic-helper: Add HDMI bridge output bus formats helper Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:31 ` [PATCH v15 08/28] drm/display: hdmi-state-helper: Act on color format DRM property Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 09/28] drm/display: hdmi-state-helper: Try subsampling in mode_valid Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 10/28] drm/amdgpu: Implement "color format" DRM property Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 11/28] drm/i915/hdmi: Add YCBCR444 handling for sink formats Nicolas Frattaroli
2026-05-22 19:12 ` Ville Syrjälä
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` Nicolas Frattaroli [this message]
2026-05-22 19:19 ` [PATCH v15 12/28] drm/i915/dp: " Ville Syrjälä
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 13/28] drm/i915/hdmi: Implement "color format" DRM property Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 14/28] drm/i915/dp: " Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 15/28] drm/rockchip: Add YUV422 output mode constants for VOP2 Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 16/28] drm/rockchip: vop2: Add RK3576 to the RG swap special case Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 17/28] drm/rockchip: vop2: Recognise 10-bit YUV422 as YUV format Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 18/28] drm/rockchip: vop2: Set correct output format for RK3576 YUV422 Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 19/28] drm/bridge: dw-hdmi-qp: Use common HDMI output bus fmts helper Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 20/28] drm/rockchip: dw_hdmi_qp: Implement "color format" DRM property Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 21/28] drm/rockchip: dw_hdmi_qp: Set supported_formats platdata Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 22/28] drm/connector: Register color format property on HDMI connectors Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 23/28] drm/tests: hdmi: Add tests for the color_format property Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 24/28] drm/tests: hdmi: Add tests for HDMI helper's mode_valid Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 25/28] drm/tests: bridge: Add KUnit tests for bridge chain format selection Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 26/28] drm/tests: bridge: Add test for HDMI output bus formats helper Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 27/28] drm/bridge: Document bridge chain format selection Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 28/28] drm/connector: Update docs of "colorspace" for color format prop Nicolas Frattaroli
2026-05-25 8:49 ` Claude review: " Claude Code Review Bot
2026-05-25 8:48 ` Claude review: Add new general DRM property "color format" Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260522-color-format-v15-12-21fb136c9df2@collabora.com \
--to=nicolas.frattaroli@collabora.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=christian.koenig@amd.com \
--cc=corbet@lwn.net \
--cc=daniel@fooishbar.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=skhan@linuxfoundation.org \
--cc=sunpeng.li@amd.com \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
--cc=wayland-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox