From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Add new general DRM property "color format"
Date: Mon, 25 May 2026 18:48:53 +1000 [thread overview]
Message-ID: <review-overall-20260522-color-format-v15-0-21fb136c9df2@collabora.com> (raw)
In-Reply-To: <20260522-color-format-v15-0-21fb136c9df2@collabora.com>
Overall Series Review
Subject: Add new general DRM property "color format"
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Patches: 31
Reviewed: 2026-05-25T18:48:53.048878
---
This is a well-structured v15 series adding a new "color format" DRM connector property allowing userspace to explicitly request RGB, YCbCr 4:4:4, 4:2:2, or 4:2:0 output. The series has extensive review history and good test coverage through KUnit tests. The architecture is sound: a new `drm_connector_color_format` enum separate from the existing `drm_output_color_format` (with an AUTO value), connector-level hooks for format override, integration into bridge chain format selection, and driver implementations for HDMI state helper, amdgpu, i915 (HDMI+DP), and rockchip.
Most patches carry R-b tags from Maxime Ripard, Dmitry Baryshkov, and Daniel Stone. The overall design — erroring out to userspace when an explicitly requested format can't be satisfied rather than silently falling back — is the right approach.
There are a few issues worth raising, mostly minor, plus one correctness concern in the i915 HDMI patch and some style nits.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 8:48 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 12:31 [PATCH v15 00/28] Add new general DRM property "color format" Nicolas Frattaroli
2026-05-22 12:31 ` [PATCH v15 01/28] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:31 ` [PATCH v15 02/28] drm/display: hdmi-state-helper: Use default case for unsupported formats Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:31 ` [PATCH v15 03/28] drm: Add new general DRM property "color format" Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:31 ` [PATCH v15 04/28] drm/connector: Let connectors have a say in their color format Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:31 ` [PATCH v15 05/28] drm/display: bridge_connector: Use HDMI color format for HDMI conns Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:31 ` [PATCH v15 06/28] drm/bridge: Act on the DRM color format property Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:31 ` [PATCH v15 07/28] drm/atomic-helper: Add HDMI bridge output bus formats helper Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:31 ` [PATCH v15 08/28] drm/display: hdmi-state-helper: Act on color format DRM property Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 09/28] drm/display: hdmi-state-helper: Try subsampling in mode_valid Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 10/28] drm/amdgpu: Implement "color format" DRM property Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 11/28] drm/i915/hdmi: Add YCBCR444 handling for sink formats Nicolas Frattaroli
2026-05-22 19:12 ` Ville Syrjälä
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 12/28] drm/i915/dp: " Nicolas Frattaroli
2026-05-22 19:19 ` Ville Syrjälä
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 13/28] drm/i915/hdmi: Implement "color format" DRM property Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 14/28] drm/i915/dp: " Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 15/28] drm/rockchip: Add YUV422 output mode constants for VOP2 Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 16/28] drm/rockchip: vop2: Add RK3576 to the RG swap special case Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 17/28] drm/rockchip: vop2: Recognise 10-bit YUV422 as YUV format Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 18/28] drm/rockchip: vop2: Set correct output format for RK3576 YUV422 Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 19/28] drm/bridge: dw-hdmi-qp: Use common HDMI output bus fmts helper Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 20/28] drm/rockchip: dw_hdmi_qp: Implement "color format" DRM property Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 21/28] drm/rockchip: dw_hdmi_qp: Set supported_formats platdata Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 22/28] drm/connector: Register color format property on HDMI connectors Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 23/28] drm/tests: hdmi: Add tests for the color_format property Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 24/28] drm/tests: hdmi: Add tests for HDMI helper's mode_valid Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 25/28] drm/tests: bridge: Add KUnit tests for bridge chain format selection Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 26/28] drm/tests: bridge: Add test for HDMI output bus formats helper Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 27/28] drm/bridge: Document bridge chain format selection Nicolas Frattaroli
2026-05-25 8:48 ` Claude review: " Claude Code Review Bot
2026-05-22 12:32 ` [PATCH v15 28/28] drm/connector: Update docs of "colorspace" for color format prop Nicolas Frattaroli
2026-05-25 8:49 ` Claude review: " Claude Code Review Bot
2026-05-25 8:48 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-23 19:43 [PATCH v16 00/28] Add new general DRM property "color format" Nicolas Frattaroli
2026-05-25 7:26 ` Claude review: " Claude Code Review Bot
2026-04-09 15:44 [PATCH v12 00/25] " Nicolas Frattaroli
2026-04-12 1:01 ` Claude review: " Claude Code Review Bot
2026-03-24 16:01 [PATCH v11 00/22] " Nicolas Frattaroli
2026-03-24 20:44 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260522-color-format-v15-0-21fb136c9df2@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox