public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Phong LE <ple@baylibre.com>, Sen Wang <sen@ti.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Javier Martinez Canillas <javierm@redhat.com>
Subject: [PATCH v5 0/3] drm/bridge: ite-it66121: Switch to HDMI helpers and fix DVI output
Date: Sat, 23 May 2026 12:40:57 +0200	[thread overview]
Message-ID: <20260523-it66121-fix-dvi-mode-v5-v5-0-33b4468162f9@redhat.com> (raw)

Display output does not work when connecting an AM625 BeaglePlay board
to a DVI monitor, because the DRM it66121 bridge driver assumes that
the sink type is always HDMI. This patch series fixes the issue.
    
Patch #1 reworks the driver to use the HDMI helpers instead of open
coding the AVI infoframes buffer management. It also implements the
needed callbacks to send HDMI Vendor Specific and Audio Infoframes.
    
Patch #2 moves the .mode_set logic to the .atomic_enable handler.
    
Patch #3 finally fixes the mentioned issue by using the display
information to determine whether HDMI or DVI mode should be set.
    
This is a v5 of the series, which addresses issues pointed out by
Maxime Ripard.
    
The patches were tested on both DVI and an HDMI monitors.

To: Andrzej Hajda <andrzej.hajda@intel.com>
To: Neil Armstrong <neil.armstrong@linaro.org>
To: Robert Foss <rfoss@kernel.org>
To: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
To: Jonas Karlman <jonas@kwiboo.se>
To: Jernej Skrabec <jernej.skrabec@gmail.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Maxime Ripard <mripard@kernel.org>
To: Thomas Zimmermann <tzimmermann@suse.de>
To: David Airlie <airlied@gmail.com>
To: Simona Vetter <simona@ffwll.ch>
To: Phong LE <ple@baylibre.com>
To: Sen Wang <sen@ti.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org

Changes in v5:
- Implement Audio InfoFrame packet support.
- Implement HDMI VSIF via Null Packet registers (Maxime Ripard).
- Use tmds_rate instead of mode->clock (Maxime Ripard).
- Drop ctx->connector, pass connector as argument (Maxime Ripard).
- Add WARN_ON for NULL connector and state checks (Maxime Ripard).
- Use ternary operator for TX mode in regmap_write (Maxime Ripard).
    
Changes in v4:
- Convert the driver to use the HDMI helpers (Maxime Ripard).
- Move .mode_set logic to .atomic_enable (Maxime Ripard).
    
Changes in v3:
- Move the HDMI/DVI mode set to .atomic_enable (Maxime Ripard).
    
Changes in v2:
- Don't store the sink type in a bridge state (Maxime Ripard).

---
Javier Martinez Canillas (3):
      drm/bridge: ite-it66121: Switch to the HDMI connector helpers
      drm/bridge: ite-it66121: Move .mode_set logic to .atomic_enable
      drm/bridge: ite-it66121: Select HDMI or DVI mode based on sink type

 drivers/gpu/drm/bridge/Kconfig       |   2 +
 drivers/gpu/drm/bridge/ite-it66121.c | 284 +++++++++++++++++++++++++----------
 2 files changed, 207 insertions(+), 79 deletions(-)
---
base-commit: 213c92ac9717e4951f052a499f91c89302889813
change-id: 20260523-it66121-fix-dvi-mode-v5-ed42429761ab

Best regards,
-- 
Javier Martinez Canillas <javierm@redhat.com>


             reply	other threads:[~2026-05-23 10:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-23 10:40 Javier Martinez Canillas [this message]
2026-05-23 10:40 ` [PATCH v5 1/3] drm/bridge: ite-it66121: Switch to the HDMI connector helpers Javier Martinez Canillas
2026-05-25  7:50   ` Claude review: " Claude Code Review Bot
2026-05-23 10:40 ` [PATCH v5 2/3] drm/bridge: ite-it66121: Move .mode_set logic to .atomic_enable Javier Martinez Canillas
2026-05-25  7:50   ` Claude review: " Claude Code Review Bot
2026-05-23 10:41 ` [PATCH v5 3/3] drm/bridge: ite-it66121: Select HDMI or DVI mode based on sink type Javier Martinez Canillas
2026-05-25  7:50   ` Claude review: " Claude Code Review Bot
2026-05-25  7:50 ` Claude review: drm/bridge: ite-it66121: Switch to HDMI helpers and fix DVI output Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260523-it66121-fix-dvi-mode-v5-v5-0-33b4468162f9@redhat.com \
    --to=javierm@redhat.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=ple@baylibre.com \
    --cc=rfoss@kernel.org \
    --cc=sen@ti.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox