Claude review: drm/bridge: ite-it66121: Select HDMI or DVI mode based on sink type

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**This is the actual bug fix and it's correct.**

```c
if (regmap_write(ctx->regmap, IT66121_HDMI_MODE_REG,
                 connector->display_info.is_hdmi ?
                 IT66121_HDMI_MODE_HDMI : IT66121_HDMI_MODE_DVI))
```

Using `connector->display_info.is_hdmi` to select between HDMI mode (BIT(0) = 1) and DVI mode (0) is the standard kernel pattern. The `IT66121_HDMI_MODE_DVI` define as `0` is slightly unconventional (defining a zero constant) but makes the intent clear and is fine.

**The connector is available at this point** because `it66121_set_mode()` (introduced in patch 2) receives it as a parameter from `atomic_enable`, where it's obtained from `drm_atomic_get_new_connector_for_encoder()`. The `display_info.is_hdmi` field is populated during EDID parsing and is reliable at enable time.

**No other mode-dependent logic needs updating.** The HDMI helpers handle infoframe suppression for DVI sinks internally, so no additional changes are needed in the infoframe callbacks.

---

**Summary:** Fix the `HDMI_TMDS_CHAR_RATE_MIN_HZ` build error in patch 1 (define it locally as `25000000ULL` or use the literal). Everything else looks good — the HDMI helper conversion is thorough and correct, and the DVI fix is clean and minimal.

---
Generated by Claude Code Patch Reviewer