public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Rob Clark <robin.clark@oss.qualcomm.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
	Akhil P Oommen <akhilpo@oss.qualcomm.com>,
	Rob Clark <robin.clark@oss.qualcomm.com>,
	Anna Maniscalco <anna.maniscalco2000@gmail.com>,
	Sean Paul <sean@poorly.run>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v10 14/16] drm/msm/a6xx: Increase pwrup_reglist size
Date: Tue, 26 May 2026 07:50:48 -0700	[thread overview]
Message-ID: <20260526145137.160554-15-robin.clark@oss.qualcomm.com> (raw)
In-Reply-To: <20260526145137.160554-1-robin.clark@oss.qualcomm.com>

To make room for appending SEL reg programming.  Without increasing the
size, we would overflow the pwrup_reglist at ~190 counters on gen8.
Or possibly fewer, considering that some gen8 counter groups also have
separate slice vs unslice SELectors.

Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
Reviewed-by: Anna Maniscalco <anna.maniscalco2000@gmail.com>
Reviewed-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
---
 drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +-
 drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
index a329d20033d7..e6c362c55dee 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
@@ -1183,7 +1183,7 @@ static int a6xx_ucode_load(struct msm_gpu *gpu)
 		msm_gem_object_set_name(a6xx_gpu->shadow_bo, "shadow");
 	}
 
-	a6xx_gpu->pwrup_reglist_ptr = msm_gem_kernel_new(gpu->dev, PAGE_SIZE,
+	a6xx_gpu->pwrup_reglist_ptr = msm_gem_kernel_new(gpu->dev, PWRUP_REGLIST_SIZE,
 							 MSM_BO_WC  | MSM_BO_MAP_PRIV,
 							 gpu->vm, &a6xx_gpu->pwrup_reglist_bo,
 							 &a6xx_gpu->pwrup_reglist_iova);
diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
index 3491a24a9320..d3f0b40787db 100644
--- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
+++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h
@@ -96,6 +96,7 @@ struct a6xx_gpu {
 	uint32_t *shadow;
 
 	struct drm_gem_object *pwrup_reglist_bo;
+#define PWRUP_REGLIST_SIZE (2 * PAGE_SIZE)
 	void *pwrup_reglist_ptr;
 	uint64_t pwrup_reglist_iova;
 	bool pwrup_reglist_emitted;
-- 
2.54.0


  parent reply	other threads:[~2026-05-26 14:54 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-26 14:50 [PATCH v10 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-26 14:50 ` [PATCH v10 01/16] drm/msm: Remove obsolete perf infrastructure Rob Clark
2026-05-27  4:42   ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 02/16] drm/msm: Allow CAP_PERFMON for setting SYSPROF Rob Clark
2026-05-27  4:42   ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 03/16] drm/msm/adreno: Sync registers from mesa Rob Clark
2026-05-27  4:42   ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 04/16] drm/msm/registers: Sync gen_header.py " Rob Clark
2026-05-27  4:42   ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 05/16] drm/msm/registers: Add perfcntr json Rob Clark
2026-05-27  4:42   ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 06/16] drm/msm: Add a6xx+ perfcntr tables Rob Clark
2026-05-27  4:42   ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 07/16] drm/msm: Add sysprof accessors Rob Clark
2026-05-27  4:42   ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 08/16] drm/msm/a6xx: Add yield & flush helper Rob Clark
2026-05-27  4:42   ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 09/16] drm/msm: Add per-context perfcntr state Rob Clark
2026-05-27  4:42   ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 10/16] drm/msm: Add basic perfcntr infrastructure Rob Clark
2026-05-27  4:42   ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 11/16] drm/msm/a6xx+: Add support to configure perfcntrs Rob Clark
2026-05-27  4:42   ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 12/16] drm/msm/a8xx: Add perfcntr flush sequence Rob Clark
2026-05-27  4:42   ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 13/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-27  4:42   ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` Rob Clark [this message]
2026-05-27  4:42   ` Claude review: drm/msm/a6xx: Increase pwrup_reglist size Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-27  4:42   ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 16/16] drm/msm/a6xx: Allow IFPC with perfcntr stream Rob Clark
2026-05-27  4:42   ` Claude review: " Claude Code Review Bot
2026-05-27  4:42 ` Claude review: drm/msm: Add PERFCNTR_CONFIG ioctl Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260526145137.160554-15-robin.clark@oss.qualcomm.com \
    --to=robin.clark@oss.qualcomm.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=akhilpo@oss.qualcomm.com \
    --cc=anna.maniscalco2000@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox