From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/a6xx: Append SEL regs to dyn pwrup reglist
Date: Wed, 27 May 2026 14:42:33 +1000 [thread overview]
Message-ID: <review-patch15-20260526145137.160554-16-robin.clark@oss.qualcomm.com> (raw)
In-Reply-To: <20260526145137.160554-16-robin.clark@oss.qualcomm.com>
Patch Review
This is the most complex patch. Key change: `a6xx_perfcntr_configure()` now appends SEL register programming to the pwrup reglist so GMU can restore them on IFPC exit.
**`cpu_gpu_lock` flex array change**: Changing `regs[62]` to `regs[]` is correct since `PWRUP_REGLIST_SIZE` now determines the actual size.
**Barrier usage**: Two `dma_wmb()` calls - one before modifying SEL entries (after clearing `dynamic_list_len`) and one after writing entries (before updating `dynamic_list_len` to include them). This is correct - it ensures the CP/GMU sees a consistent view.
**Overflow check**: `WARN_ON_ONCE(reglist > (uint32_t *)((uint8_t *)lock + PWRUP_REGLIST_SIZE))` correctly validates we don't overflow the allocated buffer.
**Race with IFPC**: The comment explains that even if we lose the race with SQE restoring registers from the old list, the ringbuffer programming will correct the SEL regs before sampling begins. This reasoning is sound.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-27 4:42 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 14:50 [PATCH v10 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-26 14:50 ` [PATCH v10 01/16] drm/msm: Remove obsolete perf infrastructure Rob Clark
2026-05-27 4:42 ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 02/16] drm/msm: Allow CAP_PERFMON for setting SYSPROF Rob Clark
2026-05-27 4:42 ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 03/16] drm/msm/adreno: Sync registers from mesa Rob Clark
2026-05-27 4:42 ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 04/16] drm/msm/registers: Sync gen_header.py " Rob Clark
2026-05-27 4:42 ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 05/16] drm/msm/registers: Add perfcntr json Rob Clark
2026-05-27 4:42 ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 06/16] drm/msm: Add a6xx+ perfcntr tables Rob Clark
2026-05-27 4:42 ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 07/16] drm/msm: Add sysprof accessors Rob Clark
2026-05-27 4:42 ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 08/16] drm/msm/a6xx: Add yield & flush helper Rob Clark
2026-05-27 4:42 ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 09/16] drm/msm: Add per-context perfcntr state Rob Clark
2026-05-27 4:42 ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 10/16] drm/msm: Add basic perfcntr infrastructure Rob Clark
2026-05-27 4:42 ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 11/16] drm/msm/a6xx+: Add support to configure perfcntrs Rob Clark
2026-05-27 4:42 ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 12/16] drm/msm/a8xx: Add perfcntr flush sequence Rob Clark
2026-05-27 4:42 ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 13/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-27 4:42 ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 14/16] drm/msm/a6xx: Increase pwrup_reglist size Rob Clark
2026-05-27 4:42 ` Claude review: " Claude Code Review Bot
2026-05-26 14:50 ` [PATCH v10 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-27 4:42 ` Claude Code Review Bot [this message]
2026-05-26 14:50 ` [PATCH v10 16/16] drm/msm/a6xx: Allow IFPC with perfcntr stream Rob Clark
2026-05-27 4:42 ` Claude review: " Claude Code Review Bot
2026-05-27 4:42 ` Claude review: drm/msm: Add PERFCNTR_CONFIG ioctl Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-22 17:32 [PATCH v9 00/16] " Rob Clark
2026-05-22 17:33 ` [PATCH v9 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-25 8:21 ` Claude review: " Claude Code Review Bot
2026-05-20 16:23 [PATCH v8 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-20 16:24 ` [PATCH v8 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-25 11:26 ` Claude review: " Claude Code Review Bot
2026-05-14 13:39 [PATCH v6 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-14 13:40 ` [PATCH v6 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-16 0:50 ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 [PATCH v5 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-11 12:59 ` [PATCH v5 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-16 5:20 ` Claude review: " Claude Code Review Bot
2026-05-06 17:10 [PATCH v3 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-06 17:10 ` [PATCH v4 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-07 3:19 ` Claude review: " Claude Code Review Bot
2026-05-04 19:06 [PATCH v3 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-04 19:06 ` [PATCH v3 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-04 22:06 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch15-20260526145137.160554-16-robin.clark@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox