From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/a6xx: Append SEL regs to dyn pwrup reglist
Date: Mon, 25 May 2026 18:21:42 +1000 [thread overview]
Message-ID: <review-patch15-20260522173349.55491-16-robin.clark@oss.qualcomm.com> (raw)
In-Reply-To: <20260522173349.55491-16-robin.clark@oss.qualcomm.com>
Patch Review
The `perfcntr_select` helper writes to both the ringbuffer and the pwrup reglist simultaneously. The reglist overflow check is a good safety guard:
```c
WARN_ON_ONCE(reglist > (uint32_t *)((uint8_t *)lock + PWRUP_REGLIST_SIZE));
```
The change from fixed `uint64_t regs[62]` to flexible `uint64_t regs[]` in `cpu_gpu_lock` is necessary to accommodate the larger reglist.
The reasoning about skipping the spinlock dance with SQE is sound: if SQE reads the old (shorter) dynamic_list_len, it restores fewer regs. Then the ringbuffer programming corrects the SEL regs before any sampling begins.
The barrier sequencing is correct:
1. Clear `dynamic_list_len` to remove old SEL entries
2. `dma_wmb()` -- GPU sees shorter list before we modify the data
3. Write new SEL entries
4. `dma_wmb()` -- GPU sees new data before longer length
5. Update `dynamic_list_len` to include new SEL entries
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 8:21 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 17:32 [PATCH v9 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-22 17:32 ` [PATCH v9 01/16] drm/msm: Remove obsolete perf infrastructure Rob Clark
2026-05-25 8:21 ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 02/16] drm/msm: Allow CAP_PERFMON for setting SYSPROF Rob Clark
2026-05-25 8:21 ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 03/16] drm/msm/adreno: Sync registers from mesa Rob Clark
2026-05-25 8:21 ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 04/16] drm/msm/registers: Sync gen_header.py " Rob Clark
2026-05-25 8:21 ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 05/16] drm/msm/registers: Add perfcntr json Rob Clark
2026-05-25 8:21 ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 06/16] drm/msm: Add a6xx+ perfcntr tables Rob Clark
2026-05-25 8:21 ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 07/16] drm/msm: Add sysprof accessors Rob Clark
2026-05-25 8:21 ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 08/16] drm/msm/a6xx: Add yield & flush helper Rob Clark
2026-05-25 8:21 ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 09/16] drm/msm: Add per-context perfcntr state Rob Clark
2026-05-25 8:21 ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 10/16] drm/msm: Add basic perfcntr infrastructure Rob Clark
2026-05-25 8:21 ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 11/16] drm/msm/a6xx+: Add support to configure perfcntrs Rob Clark
2026-05-25 8:21 ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 12/16] drm/msm/a8xx: Add perfcntr flush sequence Rob Clark
2026-05-25 8:21 ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 13/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-25 8:21 ` Claude review: " Claude Code Review Bot
2026-05-22 17:33 ` [PATCH v9 14/16] drm/msm/a6xx: Increase pwrup_reglist size Rob Clark
2026-05-25 8:21 ` Claude review: " Claude Code Review Bot
2026-05-22 17:33 ` [PATCH v9 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-25 8:21 ` Claude Code Review Bot [this message]
2026-05-22 17:33 ` [PATCH v9 16/16] drm/msm/a6xx: Allow IFPC with perfcntr stream Rob Clark
2026-05-25 8:21 ` Claude review: " Claude Code Review Bot
2026-05-25 8:21 ` Claude review: drm/msm: Add PERFCNTR_CONFIG ioctl Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-26 14:50 [PATCH v10 00/16] " Rob Clark
2026-05-26 14:50 ` [PATCH v10 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-27 4:42 ` Claude review: " Claude Code Review Bot
2026-05-20 16:23 [PATCH v8 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-20 16:24 ` [PATCH v8 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-25 11:26 ` Claude review: " Claude Code Review Bot
2026-05-14 13:39 [PATCH v6 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-14 13:40 ` [PATCH v6 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-16 0:50 ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 [PATCH v5 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-11 12:59 ` [PATCH v5 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-16 5:20 ` Claude review: " Claude Code Review Bot
2026-05-06 17:10 [PATCH v3 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-06 17:10 ` [PATCH v4 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-07 3:19 ` Claude review: " Claude Code Review Bot
2026-05-04 19:06 [PATCH v3 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-04 19:06 ` [PATCH v3 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-04 22:06 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch15-20260522173349.55491-16-robin.clark@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox