public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm: Add PERFCNTR_CONFIG ioctl
Date: Mon, 25 May 2026 18:21:38 +1000	[thread overview]
Message-ID: <review-overall-20260522173349.55491-1-robin.clark@oss.qualcomm.com> (raw)
In-Reply-To: <20260522173349.55491-1-robin.clark@oss.qualcomm.com>

Overall Series Review

Subject: drm/msm: Add PERFCNTR_CONFIG ioctl
Author: Rob Clark <robin.clark@oss.qualcomm.com>
Patches: 17
Reviewed: 2026-05-25T18:21:38.448846

---

This is a well-structured v9 series adding a `PERFCNTR_CONFIG` ioctl to the MSM DRM driver for Adreno GPU performance counter collection. The series is logically ordered: first remove the old perf infrastructure, add register definitions and tables, build up infrastructure incrementally, add the ioctl, then wire up IFPC support. The design separating global counter streaming (privileged, via fd) from local counter reservation (unprivileged, per-context) is clean. The locking is carefully thought out with good comments explaining the reasoning (especially the sel_work cancellation dance). This is v9, so it has had extensive review, and the changelogs show many issues already caught by both human reviewers and automated review (Claude).

The most notable issue I found is a missing `-EAGAIN` return in the stream read path for `O_NONBLOCK`. There are also some minor style and robustness observations. The patches are well-reviewed (R-b from Dmitry, Anna, and Akhil on most patches).

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-25  8:21 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22 17:32 [PATCH v9 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-22 17:32 ` [PATCH v9 01/16] drm/msm: Remove obsolete perf infrastructure Rob Clark
2026-05-25  8:21   ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 02/16] drm/msm: Allow CAP_PERFMON for setting SYSPROF Rob Clark
2026-05-25  8:21   ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 03/16] drm/msm/adreno: Sync registers from mesa Rob Clark
2026-05-25  8:21   ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 04/16] drm/msm/registers: Sync gen_header.py " Rob Clark
2026-05-25  8:21   ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 05/16] drm/msm/registers: Add perfcntr json Rob Clark
2026-05-25  8:21   ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 06/16] drm/msm: Add a6xx+ perfcntr tables Rob Clark
2026-05-25  8:21   ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 07/16] drm/msm: Add sysprof accessors Rob Clark
2026-05-25  8:21   ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 08/16] drm/msm/a6xx: Add yield & flush helper Rob Clark
2026-05-25  8:21   ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 09/16] drm/msm: Add per-context perfcntr state Rob Clark
2026-05-25  8:21   ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 10/16] drm/msm: Add basic perfcntr infrastructure Rob Clark
2026-05-25  8:21   ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 11/16] drm/msm/a6xx+: Add support to configure perfcntrs Rob Clark
2026-05-25  8:21   ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 12/16] drm/msm/a8xx: Add perfcntr flush sequence Rob Clark
2026-05-25  8:21   ` Claude review: " Claude Code Review Bot
2026-05-22 17:32 ` [PATCH v9 13/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-25  8:21   ` Claude review: " Claude Code Review Bot
2026-05-22 17:33 ` [PATCH v9 14/16] drm/msm/a6xx: Increase pwrup_reglist size Rob Clark
2026-05-25  8:21   ` Claude review: " Claude Code Review Bot
2026-05-22 17:33 ` [PATCH v9 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-25  8:21   ` Claude review: " Claude Code Review Bot
2026-05-22 17:33 ` [PATCH v9 16/16] drm/msm/a6xx: Allow IFPC with perfcntr stream Rob Clark
2026-05-25  8:21   ` Claude review: " Claude Code Review Bot
2026-05-25  8:21 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-05-26 14:50 [PATCH v10 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-26 14:50 ` [PATCH v10 13/16] " Rob Clark
2026-05-27  4:42   ` Claude review: " Claude Code Review Bot
2026-05-27  4:42 ` Claude Code Review Bot
2026-05-20 16:23 [PATCH v8 00/16] " Rob Clark
2026-05-20 16:24 ` [PATCH v8 13/16] " Rob Clark
2026-05-25 11:26   ` Claude review: " Claude Code Review Bot
2026-05-25 11:26 ` Claude Code Review Bot
2026-05-14 13:39 [PATCH v6 00/16] " Rob Clark
2026-05-14 13:40 ` [PATCH v6 13/16] " Rob Clark
2026-05-16  0:50   ` Claude review: " Claude Code Review Bot
2026-05-16  0:50 ` Claude Code Review Bot
2026-05-11 12:59 [PATCH v5 00/16] " Rob Clark
2026-05-11 12:59 ` [PATCH v5 13/16] " Rob Clark
2026-05-16  5:20   ` Claude review: " Claude Code Review Bot
2026-05-16  5:20 ` Claude Code Review Bot
2026-05-06 17:10 [PATCH v3 00/16] " Rob Clark
2026-05-06 17:10 ` [PATCH v4 13/16] " Rob Clark
2026-05-07  3:19   ` Claude review: " Claude Code Review Bot
2026-05-07  3:19 ` Claude Code Review Bot
2026-05-04 19:06 [PATCH v3 00/16] " Rob Clark
2026-05-04 19:06 ` [PATCH v3 13/16] " Rob Clark
2026-05-04 22:06   ` Claude review: " Claude Code Review Bot
2026-05-04 22:06 ` Claude Code Review Bot
2026-04-20 22:25 [PATCH 00/13] " Rob Clark
2026-04-20 22:25 ` [PATCH 13/13] " Rob Clark
2026-04-22 23:13   ` Claude review: " Claude Code Review Bot
2026-04-22 23:13 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260522173349.55491-1-robin.clark@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox