Claude review: drm/msm: Add PERFCNTR_CONFIG ioctl

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/msm: Add PERFCNTR_CONFIG ioctl
Author: Rob Clark <robin.clark@oss.qualcomm.com>
Patches: 21
Reviewed: 2026-05-16T15:20:21.310861

---

This is a well-structured 16-patch series from Rob Clark adding a new `PERFCNTR_CONFIG` ioctl to the MSM DRM driver, supporting both global counter collection (via a stream fd) and per-context local counter reservation. The architecture is sound: counters are allocated from the top to avoid conflict with old UMD, a circular buffer streams samples to userspace, and IFPC is handled cleanly via the pwrup reglist.

However, there are several issues that need addressing before merge:

**Critical**: Stack buffer overflow in the ioctl's `copy_from_user` with unchecked `group_stride` (Patch 13). NULL pointer dereference in `msm_perfcntr_init` error path (Patch 10).

**Medium**: Integer overflow / undefined behavior with `1 << bufsz_shift` (Patch 13). Off-by-one in bounds check (Patch 10). Inconsistent null-guard in suspend path (Patch 10).

Patches 1-5 have Reviewed-by from Dmitry Baryshkov. Patches 6-16 do not.

---

---
Generated by Claude Code Patch Reviewer