public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Rob Clark <robin.clark@oss.qualcomm.com>
Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	freedreno@lists.freedesktop.org,
	Akhil P Oommen <akhilpo@oss.qualcomm.com>,
	Sean Paul <sean@poorly.run>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Dmitry Baryshkov <lumag@kernel.org>,
	Abhinav Kumar <abhinav.kumar@linux.dev>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	Marijn Suijten <marijn.suijten@somainline.org>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 09/16] drm/msm: Add per-context perfcntr state
Date: Wed, 13 May 2026 21:57:34 +0300	[thread overview]
Message-ID: <npv72eupja2jczwrhssujypuigzplbqcid2qt6yjo6fj5wftoj@u6uqcxj2ic2f> (raw)
In-Reply-To: <20260511130017.96867-10-robin.clark@oss.qualcomm.com>

On Mon, May 11, 2026 at 05:59:22AM -0700, Rob Clark wrote:
> The upcoming PERFCNTR_CONFIG ioctl will allow for both global counter
> collection, and per-context counter reservation for local (ie. within
> a single GEM_SUBMIT ioctl) counter collection.
> 
> Any number of contexts can reserve the same counters, but we will need
> to ensure that counters reserved for local counter collection do not
> conflict with counters used for global counter collection.
> 
> So add tracking for per-context local counter reservations.
> 
> Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
> ---
>  drivers/gpu/drm/msm/msm_gpu.h         |  5 +++++
>  drivers/gpu/drm/msm/msm_perfcntr.h    | 21 +++++++++++++++++++++
>  drivers/gpu/drm/msm/msm_submitqueue.c |  1 +
>  3 files changed, 27 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

  reply	other threads:[~2026-05-13 18:57 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 12:59 [PATCH v5 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-11 12:59 ` [PATCH v5 01/16] drm/msm: Remove obsolete perf infrastructure Rob Clark
2026-05-16  5:20   ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 02/16] drm/msm: Allow CAP_PERFMON for setting SYSPROF Rob Clark
2026-05-16  5:20   ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 03/16] drm/msm/adreno: Sync registers from mesa Rob Clark
2026-05-16  5:20   ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 04/16] drm/msm/registers: Sync gen_header.py " Rob Clark
2026-05-16  5:20   ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 05/16] drm/msm/registers: Add perfcntr json Rob Clark
2026-05-16  5:20   ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 06/16] drm/msm: Add a6xx+ perfcntr tables Rob Clark
2026-05-13 18:55   ` Dmitry Baryshkov
2026-05-16  5:20   ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 07/16] drm/msm: Add sysprof accessors Rob Clark
2026-05-16  5:20   ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 08/16] drm/msm/a6xx: Add yield & flush helper Rob Clark
2026-05-13 18:56   ` Dmitry Baryshkov
2026-05-16  5:20   ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 09/16] drm/msm: Add per-context perfcntr state Rob Clark
2026-05-13 18:57   ` Dmitry Baryshkov [this message]
2026-05-16  5:20   ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 10/16] drm/msm: Add basic perfcntr infrastructure Rob Clark
2026-05-13 21:12   ` Anna Maniscalco
2026-05-16  5:20   ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 11/16] drm/msm/a6xx+: Add support to configure perfcntrs Rob Clark
2026-05-16  5:20   ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 12/16] drm/msm/a8xx: Add perfcntr flush sequence Rob Clark
2026-05-16  5:20   ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 13/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-16  5:20   ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 14/16] drm/msm/a6xx: Increase pwrup_reglist size Rob Clark
2026-05-16  5:20   ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-16  5:20   ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 16/16] drm/msm/a6xx: Allow IFPC with perfcntr stream Rob Clark
2026-05-16  5:20   ` Claude review: " Claude Code Review Bot
2026-05-16  5:20 ` Claude review: drm/msm: Add PERFCNTR_CONFIG ioctl Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=npv72eupja2jczwrhssujypuigzplbqcid2qt6yjo6fj5wftoj@u6uqcxj2ic2f \
    --to=dmitry.baryshkov@oss.qualcomm.com \
    --cc=abhinav.kumar@linux.dev \
    --cc=airlied@gmail.com \
    --cc=akhilpo@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lumag@kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=sean@poorly.run \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox