From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/a8xx: Add perfcntr flush sequence
Date: Sat, 16 May 2026 15:20:24 +1000 [thread overview]
Message-ID: <review-patch12-20260511130017.96867-13-robin.clark@oss.qualcomm.com> (raw)
In-Reply-To: <20260511130017.96867-13-robin.clark@oss.qualcomm.com>
Patch Review
The flush writes to both `RBBM_PERFCTR_FLUSH_HOST_CMD` and `RBBM_SLICE_PERFCTR_FLUSH_HOST_CMD`, but only polls `RBBM_PERFCTR_FLUSH_HOST_STATUS`. Is there a separate status register for the slice flush that should also be polled, or does the single status register cover both? Worth confirming that the slice flush doesn't have its own independent completion status.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 5:20 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 12:59 [PATCH v5 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-11 12:59 ` [PATCH v5 01/16] drm/msm: Remove obsolete perf infrastructure Rob Clark
2026-05-16 5:20 ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 02/16] drm/msm: Allow CAP_PERFMON for setting SYSPROF Rob Clark
2026-05-16 5:20 ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 03/16] drm/msm/adreno: Sync registers from mesa Rob Clark
2026-05-16 5:20 ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 04/16] drm/msm/registers: Sync gen_header.py " Rob Clark
2026-05-16 5:20 ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 05/16] drm/msm/registers: Add perfcntr json Rob Clark
2026-05-16 5:20 ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 06/16] drm/msm: Add a6xx+ perfcntr tables Rob Clark
2026-05-13 18:55 ` Dmitry Baryshkov
2026-05-16 5:20 ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 07/16] drm/msm: Add sysprof accessors Rob Clark
2026-05-16 5:20 ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 08/16] drm/msm/a6xx: Add yield & flush helper Rob Clark
2026-05-13 18:56 ` Dmitry Baryshkov
2026-05-16 5:20 ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 09/16] drm/msm: Add per-context perfcntr state Rob Clark
2026-05-13 18:57 ` Dmitry Baryshkov
2026-05-16 5:20 ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 10/16] drm/msm: Add basic perfcntr infrastructure Rob Clark
2026-05-13 21:12 ` Anna Maniscalco
2026-05-16 5:20 ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 11/16] drm/msm/a6xx+: Add support to configure perfcntrs Rob Clark
2026-05-16 5:20 ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 12/16] drm/msm/a8xx: Add perfcntr flush sequence Rob Clark
2026-05-16 5:20 ` Claude Code Review Bot [this message]
2026-05-11 12:59 ` [PATCH v5 13/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-16 5:20 ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 14/16] drm/msm/a6xx: Increase pwrup_reglist size Rob Clark
2026-05-16 5:20 ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-16 5:20 ` Claude review: " Claude Code Review Bot
2026-05-11 12:59 ` [PATCH v5 16/16] drm/msm/a6xx: Allow IFPC with perfcntr stream Rob Clark
2026-05-16 5:20 ` Claude review: " Claude Code Review Bot
2026-05-16 5:20 ` Claude review: drm/msm: Add PERFCNTR_CONFIG ioctl Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-14 13:39 [PATCH v6 00/16] " Rob Clark
2026-05-14 13:40 ` [PATCH v6 12/16] drm/msm/a8xx: Add perfcntr flush sequence Rob Clark
2026-05-16 0:50 ` Claude review: " Claude Code Review Bot
2026-05-06 17:10 [PATCH v3 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-06 17:10 ` [PATCH v4 12/16] drm/msm/a8xx: Add perfcntr flush sequence Rob Clark
2026-05-07 3:19 ` Claude review: " Claude Code Review Bot
2026-05-04 19:06 [PATCH v3 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-04 19:06 ` [PATCH v3 12/16] drm/msm/a8xx: Add perfcntr flush sequence Rob Clark
2026-05-04 22:06 ` Claude review: " Claude Code Review Bot
2026-04-20 22:25 [PATCH 00/13] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-04-20 22:25 ` [PATCH 12/13] drm/msm/a8xx: Add perfcntr flush sequence Rob Clark
2026-04-22 23:13 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch12-20260511130017.96867-13-robin.clark@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox