public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Jason Baron <jbaron@akamai.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Petr Pavlu <petr.pavlu@suse.com>,
	Daniel Gomez <da.gomez@kernel.org>,
	Sami Tolvanen <samitolvanen@google.com>,
	Aaron Tomlin <atomlin@atomlin.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Shuah Khan <shuah@kernel.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org, linux-modules@vger.kernel.org,
	linux-kselftest@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Jim Cromie <jim.cromie@gmail.com>,
	Louis Chauvet <louis.chauvet@bootlin.com>
Subject: [PATCH v3 10/24] dyndbg: reword "class unknown," to "class:_UNKNOWN_"
Date: Mon, 01 Jun 2026 12:04:56 +0000	[thread overview]
Message-ID: <20260601-dd-maint-2-v3-10-4a15b241bd3c@gmail.com> (raw)
In-Reply-To: <20260601-dd-maint-2-v3-0-4a15b241bd3c@gmail.com>

When a dyndbg classname is unknown to a kernel module, the callsite is
un-addressable via >control queries.

The control-file displays this condition as "class unknown,"
currently.  That spelling is sub-optimal/too-generic, so change it to
"class:_UNKNOWN_" to loudly announce the erroneous situation, and to
make it uniquely greppable.

NB: while this might be seen as a user-visible change, this shouldn't
disqualify the change:

a- it reports classmap coding error condition, which should be
   detected before review.
b- SHOUTING the error makes it uniquely greppable.
c- the classmap feature is marked BROKEN for its only current user.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
 lib/dynamic_debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 6b1e983cfedc..a9caf84ddb22 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -1166,7 +1166,7 @@ static int ddebug_proc_show(struct seq_file *m, void *p)
 		if (class)
 			seq_printf(m, " class:%s", class);
 		else
-			seq_printf(m, " class unknown, _id:%d", dp->class_id);
+			seq_printf(m, " class:_UNKNOWN_ _id:%d", dp->class_id);
 	}
 	seq_putc(m, '\n');
 

-- 
2.54.0


  parent reply	other threads:[~2026-06-01 12:05 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 12:04 [PATCH v3 00/24] dynamic-debug cleanups refactors maintenance + alignment fix Jim Cromie
2026-06-01 12:04 ` [PATCH v3 01/24] docs/dyndbg: update examples \012 to \n Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 02/24] docs/dyndbg: explain flags parse 1st Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 03/24] vmlinux.lds.h: refactor BOUNDED_SECTION_* macros into bounded_sections.lds.h Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 04/24] vmlinux.lds.h: drop unused HEADERED_SECTION* macros Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 05/24] vmlinux.lds.h: Fix ALIGN(8) omission causing NULL ptr on i386 Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 06/24] vmlinux.lds.h: remove redundant ALIGN(8) directives Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 07/24] dyndbg.lds.S: fix lost dyndbg sections in modules Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 08/24] dyndbg: factor ddebug_match_desc out from ddebug_change Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 09/24] dyndbg: add stub macro for DECLARE_DYNDBG_CLASSMAP Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` Jim Cromie [this message]
2026-06-04  4:06   ` Claude review: dyndbg: reword "class unknown," to "class:_UNKNOWN_" Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 11/24] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 12/24] dyndbg: drop NUM_TYPE_ARGS Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 13/24] dyndbg: reduce verbose/debug clutter Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 14/24] dyndbg: refactor param_set_dyndbg_classes and below Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 15/24] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 16/24] dyndbg: replace classmap list with an array-slice Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 17/24] dyndbg: macrofy a 2-index for-loop pattern Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 18/24] dyndbg: Upgrade class param storage to u64 for 64-bit classmaps Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 19/24] dyndbg,module: make proper substructs in _ddebug_info Jim Cromie
2026-06-04  4:07   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 20/24] dyndbg: move mod_name down from struct ddebug_table to _ddebug_info Jim Cromie
2026-06-04  4:07   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 21/24] dyndbg: hoist classmap-filter-by-modname up to ddebug_add_module Jim Cromie
2026-06-04  4:07   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 22/24] selftests-dyndbg: add a dynamic_debug run_tests target Jim Cromie
2026-06-04  4:07   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 23/24] dyndbg: change __dynamic_func_call_cls* macros into expressions Jim Cromie
2026-06-04  4:07   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 24/24] dynamic_debug: use KBUILD_MODFILE for unique builtin module names Jim Cromie
2026-06-04  4:07   ` Claude review: " Claude Code Review Bot
2026-06-04  4:06 ` Claude review: dynamic-debug cleanups refactors maintenance + alignment fix Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260601-dd-maint-2-v3-10-4a15b241bd3c@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=airlied@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=atomlin@atomlin.com \
    --cc=corbet@lwn.net \
    --cc=da.gomez@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jbaron@akamai.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=louis.chauvet@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mcgrof@kernel.org \
    --cc=mripard@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=samitolvanen@google.com \
    --cc=shuah@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=skhan@linuxfoundation.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox