public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Jason Baron <jbaron@akamai.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Petr Pavlu <petr.pavlu@suse.com>,
	Daniel Gomez <da.gomez@kernel.org>,
	Sami Tolvanen <samitolvanen@google.com>,
	Aaron Tomlin <atomlin@atomlin.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Shuah Khan <shuah@kernel.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arch@vger.kernel.org, linux-modules@vger.kernel.org,
	linux-kselftest@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH v3 03/24] vmlinux.lds.h: refactor BOUNDED_SECTION_* macros into bounded_sections.lds.h
Date: Mon, 01 Jun 2026 12:04:49 +0000	[thread overview]
Message-ID: <20260601-dd-maint-2-v3-3-4a15b241bd3c@gmail.com> (raw)
In-Reply-To: <20260601-dd-maint-2-v3-0-4a15b241bd3c@gmail.com>

Move BOUNDED_SECTION_* macros to a new helper file:
include/asm-generic/bounded_sections.lds.h and include it back into
vmlinux.lds.h.  This allows its reuse later to fix a failure to keep
dyndbg sections in some circumstances.

NOTES:

These macros are only for use in vmlinux.lds.h, where the _start &
_end symbols are needed.  Modules keep sections separate in ELF
sections, with their boundaries known, so the _start and _end are not
useful, and may confuse tools not expecting them.

This patch ignores a checkpatch warning, because new file is covered
by "GENERIC INCLUDE/ASM HEADER FILES" in MAINTAINERS

CC: Arnd Bergmann <arnd@arndb.de>
CC: linux-arch@vger.kernel.org
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
v3: move include to top
---
 include/asm-generic/bounded_sections.lds.h | 36 ++++++++++++++++++++++++++++++
 include/asm-generic/vmlinux.lds.h          | 31 +------------------------
 2 files changed, 37 insertions(+), 30 deletions(-)

diff --git a/include/asm-generic/bounded_sections.lds.h b/include/asm-generic/bounded_sections.lds.h
new file mode 100644
index 000000000000..8c29293ca7fb
--- /dev/null
+++ b/include/asm-generic/bounded_sections.lds.h
@@ -0,0 +1,36 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+
+#ifndef _ASM_GENERIC_BOUNDED_SECTIONS_H
+#define _ASM_GENERIC_BOUNDED_SECTIONS_H
+
+#define BOUNDED_SECTION_PRE_LABEL(_sec_, _label_, _BEGIN_, _END_)	\
+	_BEGIN_##_label_ = .;						\
+	KEEP(*(_sec_))							\
+	_END_##_label_ = .;
+
+#define BOUNDED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_)	\
+	_label_##_BEGIN_ = .;						\
+	KEEP(*(_sec_))							\
+	_label_##_END_ = .;
+
+#define BOUNDED_SECTION_BY(_sec_, _label_)				\
+	BOUNDED_SECTION_PRE_LABEL(_sec_, _label_, __start, __stop)
+
+#define BOUNDED_SECTION(_sec)	 BOUNDED_SECTION_BY(_sec, _sec)
+
+#define HEADERED_SECTION_PRE_LABEL(_sec_, _label_, _BEGIN_, _END_, _HDR_) \
+	_HDR_##_label_	= .;						\
+	KEEP(*(.gnu.linkonce.##_sec_))					\
+	BOUNDED_SECTION_PRE_LABEL(_sec_, _label_, _BEGIN_, _END_)
+
+#define HEADERED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_, _HDR_) \
+	_label_##_HDR_ = .;						\
+	KEEP(*(.gnu.linkonce.##_sec_))					\
+	BOUNDED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_)
+
+#define HEADERED_SECTION_BY(_sec_, _label_)				\
+	HEADERED_SECTION_PRE_LABEL(_sec_, _label_, __start, __stop)
+
+#define HEADERED_SECTION(_sec)	 HEADERED_SECTION_BY(_sec, _sec)
+
+#endif /* _ASM_GENERIC_BOUNDED_SECTIONS_H */
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index 60c8c22fd3e4..9c61dd083f26 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -50,6 +50,7 @@
  *               [__nosave_begin, __nosave_end] for the nosave data
  */
 
+#include <asm-generic/bounded_sections.lds.h>
 #include <asm-generic/codetag.lds.h>
 
 #ifndef LOAD_OFFSET
@@ -211,36 +212,6 @@
 # endif
 #endif
 
-#define BOUNDED_SECTION_PRE_LABEL(_sec_, _label_, _BEGIN_, _END_)	\
-	_BEGIN_##_label_ = .;						\
-	KEEP(*(_sec_))							\
-	_END_##_label_ = .;
-
-#define BOUNDED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_)	\
-	_label_##_BEGIN_ = .;						\
-	KEEP(*(_sec_))							\
-	_label_##_END_ = .;
-
-#define BOUNDED_SECTION_BY(_sec_, _label_)				\
-	BOUNDED_SECTION_PRE_LABEL(_sec_, _label_, __start, __stop)
-
-#define BOUNDED_SECTION(_sec)	 BOUNDED_SECTION_BY(_sec, _sec)
-
-#define HEADERED_SECTION_PRE_LABEL(_sec_, _label_, _BEGIN_, _END_, _HDR_) \
-	_HDR_##_label_	= .;						\
-	KEEP(*(.gnu.linkonce.##_sec_))					\
-	BOUNDED_SECTION_PRE_LABEL(_sec_, _label_, _BEGIN_, _END_)
-
-#define HEADERED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_, _HDR_) \
-	_label_##_HDR_ = .;						\
-	KEEP(*(.gnu.linkonce.##_sec_))					\
-	BOUNDED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_)
-
-#define HEADERED_SECTION_BY(_sec_, _label_)				\
-	HEADERED_SECTION_PRE_LABEL(_sec_, _label_, __start, __stop)
-
-#define HEADERED_SECTION(_sec)	 HEADERED_SECTION_BY(_sec, _sec)
-
 #ifdef CONFIG_TRACE_BRANCH_PROFILING
 #define LIKELY_PROFILE()						\
 	BOUNDED_SECTION_BY(_ftrace_annotated_branch, _annotated_branch_profile)

-- 
2.54.0


  parent reply	other threads:[~2026-06-01 12:05 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 12:04 [PATCH v3 00/24] dynamic-debug cleanups refactors maintenance + alignment fix Jim Cromie
2026-06-01 12:04 ` [PATCH v3 01/24] docs/dyndbg: update examples \012 to \n Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 02/24] docs/dyndbg: explain flags parse 1st Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` Jim Cromie [this message]
2026-06-04  4:06   ` Claude review: vmlinux.lds.h: refactor BOUNDED_SECTION_* macros into bounded_sections.lds.h Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 04/24] vmlinux.lds.h: drop unused HEADERED_SECTION* macros Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 05/24] vmlinux.lds.h: Fix ALIGN(8) omission causing NULL ptr on i386 Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 06/24] vmlinux.lds.h: remove redundant ALIGN(8) directives Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 07/24] dyndbg.lds.S: fix lost dyndbg sections in modules Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 08/24] dyndbg: factor ddebug_match_desc out from ddebug_change Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 09/24] dyndbg: add stub macro for DECLARE_DYNDBG_CLASSMAP Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 10/24] dyndbg: reword "class unknown," to "class:_UNKNOWN_" Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 11/24] dyndbg-API: remove DD_CLASS_TYPE_(DISJOINT|LEVEL)_NAMES and code Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 12/24] dyndbg: drop NUM_TYPE_ARGS Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:04 ` [PATCH v3 13/24] dyndbg: reduce verbose/debug clutter Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 14/24] dyndbg: refactor param_set_dyndbg_classes and below Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 15/24] dyndbg: tighten fn-sig of ddebug_apply_class_bitmap Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 16/24] dyndbg: replace classmap list with an array-slice Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 17/24] dyndbg: macrofy a 2-index for-loop pattern Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 18/24] dyndbg: Upgrade class param storage to u64 for 64-bit classmaps Jim Cromie
2026-06-04  4:06   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 19/24] dyndbg,module: make proper substructs in _ddebug_info Jim Cromie
2026-06-04  4:07   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 20/24] dyndbg: move mod_name down from struct ddebug_table to _ddebug_info Jim Cromie
2026-06-04  4:07   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 21/24] dyndbg: hoist classmap-filter-by-modname up to ddebug_add_module Jim Cromie
2026-06-04  4:07   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 22/24] selftests-dyndbg: add a dynamic_debug run_tests target Jim Cromie
2026-06-04  4:07   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 23/24] dyndbg: change __dynamic_func_call_cls* macros into expressions Jim Cromie
2026-06-04  4:07   ` Claude review: " Claude Code Review Bot
2026-06-01 12:05 ` [PATCH v3 24/24] dynamic_debug: use KBUILD_MODFILE for unique builtin module names Jim Cromie
2026-06-04  4:07   ` Claude review: " Claude Code Review Bot
2026-06-04  4:06 ` Claude review: dynamic-debug cleanups refactors maintenance + alignment fix Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260601-dd-maint-2-v3-3-4a15b241bd3c@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=airlied@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=atomlin@atomlin.com \
    --cc=corbet@lwn.net \
    --cc=da.gomez@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jbaron@akamai.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mcgrof@kernel.org \
    --cc=mripard@kernel.org \
    --cc=petr.pavlu@suse.com \
    --cc=samitolvanen@google.com \
    --cc=shuah@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=skhan@linuxfoundation.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox