[PATCH RESEND] drm/bridge: sii902x: inline i2c_check_functionality check

[PATCH RESEND] drm/bridge: sii902x: inline i2c_check_functionality check

[Thorsten Blum]

Inline the i2c_check_functionality() check, since the function returns a
boolean status rather than an error code.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 drivers/gpu/drm/bridge/sii902x.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index ea543be4ae3e..38d176d4eef2 100644
--- a/drivers/gpu/drm/bridge/sii902x.c
+++ b/drivers/gpu/drm/bridge/sii902x.c
@@ -1158,9 +1158,7 @@ static int sii902x_probe(struct i2c_client *client)
 	static const char * const supplies[] = {"iovcc", "cvcc12"};
 	int ret;
 
-	ret = i2c_check_functionality(client->adapter,
-				      I2C_FUNC_SMBUS_BYTE_DATA);
-	if (!ret) {
+	if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
 		dev_err(dev, "I2C adapter not suitable\n");
 		return -EIO;
 	}

Re: [PATCH RESEND] drm/bridge: sii902x: inline i2c_check_functionality check

[Dmitry Baryshkov]

On Sun, May 17, 2026 at 07:21:37PM +0200, Thorsten Blum wrote:
> Inline the i2c_check_functionality() check, since the function returns a
> boolean status rather than an error code.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  drivers/gpu/drm/bridge/sii902x.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

[PATCH RESEND] drm/bridge: sii902x: inline i2c_check_functionality check

[Thorsten Blum]

Inline the i2c_check_functionality() check, since the function returns a
boolean status rather than an error code.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 drivers/gpu/drm/bridge/sii902x.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c
index 12497f5ce4ff..0cc738e2dd63 100644
--- a/drivers/gpu/drm/bridge/sii902x.c
+++ b/drivers/gpu/drm/bridge/sii902x.c
@@ -1158,9 +1158,7 @@ static int sii902x_probe(struct i2c_client *client)
 	static const char * const supplies[] = {"iovcc", "cvcc12"};
 	int ret;
 
-	ret = i2c_check_functionality(client->adapter,
-				      I2C_FUNC_SMBUS_BYTE_DATA);
-	if (!ret) {
+	if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
 		dev_err(dev, "I2C adapter not suitable\n");
 		return -EIO;
 	}

Re: [PATCH RESEND] drm/bridge: sii902x: inline i2c_check_functionality check

[Luca Ceresoli]

On Wed Jun 3, 2026 at 12:31 AM CEST, Thorsten Blum wrote:
> Inline the i2c_check_functionality() check, since the function returns a
> boolean status rather than an error code.
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Claude review: drm/bridge: sii902x: inline i2c_check_functionality check

[Claude Code Review Bot]

Overall Series Review

Subject: drm/bridge: sii902x: inline i2c_check_functionality check
Author: Thorsten Blum <thorsten.blum@linux.dev>
Patches: 2
Reviewed: 2026-06-04T12:14:08.715137

---

This is a single, trivial cleanup patch. It inlines the `i2c_check_functionality()` call directly into the `if` condition, removing the unnecessary intermediate `ret` variable assignment. The change is correct: `i2c_check_functionality()` returns a `bool` (actually `u32` interpreted as boolean), not an error code, so storing it in `int ret` was misleading — it was never used as an error code, only checked for zero/non-zero.

The patch is safe and already has a Reviewed-by tag from Dmitry Baryshkov.

**Verdict: No issues. Good to merge.**

---
Generated by Claude Code Patch Reviewer

Claude review: drm/bridge: sii902x: inline i2c_check_functionality check

[Claude Code Review Bot]

Patch Review

**Status: Clean**

The change replaces:
```c
ret = i2c_check_functionality(client->adapter,
                              I2C_FUNC_SMBUS_BYTE_DATA);
if (!ret) {
```
with:
```c
if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
```

This is correct because:

1. **`i2c_check_functionality()` returns boolean, not an error code.** Assigning its result to `ret` is misleading — it suggests an error-code pattern (check `ret < 0`), but the old code was already checking `!ret` which is the boolean pattern. Inlining makes the intent clearer.

2. **`ret` is still used later in the function** (line 1213: `ret = devm_regulator_bulk_get_enable(...)`) so there is no risk of an unused-variable warning from removing this one assignment.

3. **No functional change** — the behavior is identical before and after.

The commit message is accurate and concise. The patch already carries a Reviewed-by tag.

---
Generated by Claude Code Patch Reviewer