From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org,
nouveau@lists.freedesktop.org
Cc: Alexandre Courbot <acourbot@nvidia.com>,
Gary Guo <gary@garyguo.net>,
Christian König <christian.koenig@amd.com>,
driver-core@lists.linux.dev, Miguel Ojeda <ojeda@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Alice Ryhl <aliceryhl@google.com>,
Simona Vetter <simona@ffwll.ch>,
linux-kernel@vger.kernel.org,
Sumit Semwal <sumit.semwal@linaro.org>,
linux-media@vger.kernel.org,
"Rafael J . Wysocki" <rafael@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@gmail.com>,
Benno Lossin <lossin@kernel.org>,
linaro-mm-sig@lists.linaro.org,
Danilo Krummrich <dakr@kernel.org>,
Mukesh Kumar Chaurasiya <mkchauras@gmail.com>,
Asahi Lina <lina+kernel@asahilina.net>,
Daniel Almeida <daniel.almeida@collabora.com>,
Lyude Paul <lyude@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH v17 5/6] rust: sync: Add SetOnce::reset()
Date: Wed, 3 Jun 2026 15:42:34 -0400 [thread overview]
Message-ID: <20260603195210.693856-6-lyude@redhat.com> (raw)
In-Reply-To: <20260603195210.693856-1-lyude@redhat.com>
This function simply drops the contents of the SetOnce, given a mutable
reference - since that proves we have exclusive access to the SetOnce.
Additionally, update the invariants for SetOnce to make it clear as to why
this is safe.
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
rust/kernel/sync/set_once.rs | 60 +++++++++++++++++++++++++++++++-----
1 file changed, 52 insertions(+), 8 deletions(-)
diff --git a/rust/kernel/sync/set_once.rs b/rust/kernel/sync/set_once.rs
index 139cef05e935f..d6e4fc2695673 100644
--- a/rust/kernel/sync/set_once.rs
+++ b/rust/kernel/sync/set_once.rs
@@ -15,7 +15,7 @@
///
/// # Invariants
///
-/// - `init` may only increase in value.
+/// - `init` may only increase in value, unless modified through a mutable reference.
/// - `init` may only assume values in the range `0..=2`.
/// - `init == 0` if and only if `value` is uninitialized.
/// - `init == 1` if and only if there is exactly one thread with exclusive
@@ -110,17 +110,61 @@ pub fn copy(&self) -> Option<T>
{
self.as_ref().copied()
}
+
+ /// # Safety
+ ///
+ /// If this function returns `true`, `self` must be freed or `init` must be reset to `0`.
+ unsafe fn drop_val(&mut self) -> bool {
+ if *self.init.get_mut() != 2 {
+ return false;
+ }
+
+ let value = self.value.get_mut();
+ // SAFETY: Via our type invariants, `init` == 2 means `value` is initialized.
+ unsafe { value.assume_init_drop() };
+
+ true
+ }
+
+ /// Unset the [`SetOnce`].
+ ///
+ /// After this function is called, the [`SetOnce`] is empty and uninitialized. This function is
+ /// mainly intended for usage in destructors.
+ ///
+ /// Returns `true` if `self` was previously initialized.
+ ///
+ /// # Example
+ ///
+ /// ```
+ /// # use kernel::sync::SetOnce;
+ /// let mut value = SetOnce::new();
+ /// assert_eq!(value.populate(67), true);
+ ///
+ /// assert_eq!(value.reset(), true);
+ /// assert!(value.as_ref().is_none());
+ /// assert_eq!(value.reset(), false);
+ ///
+ /// assert_eq!(value.populate(69), true);
+ /// ```
+ pub fn reset(&mut self) -> bool {
+ // SAFETY: We write `0` to init below if this returns true.
+ let dropped = unsafe { self.drop_val() };
+ if dropped {
+ // INVARIANT:
+ // - We set `init` back to 0 through a mutable reference.
+ // - We dropped `value` above.
+ *self.init.get_mut() = 0;
+ }
+
+ dropped
+ }
}
impl<T> Drop for SetOnce<T> {
+ #[inline(always)]
fn drop(&mut self) {
- if *self.init.get_mut() == 2 {
- let value = self.value.get_mut();
- // SAFETY: By the type invariants of `Self`, `self.init == 2` means that `self.value`
- // contains a valid value. We have exclusive access, as we hold a `mut` reference to
- // `self`.
- unsafe { value.assume_init_drop() };
- }
+ // SAFETY: We are dropping this value.
+ unsafe { self.drop_val() };
}
}
--
2.54.0
next prev parent reply other threads:[~2026-06-03 19:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 19:42 [PATCH v17 0/6] Rust bindings for gem shmem Lyude Paul
2026-06-03 19:42 ` [PATCH v17 1/6] rust: drm: gem: shmem: Fix Default implementation for ObjectConfig Lyude Paul
2026-06-04 1:29 ` Claude review: " Claude Code Review Bot
2026-06-03 19:42 ` [PATCH v17 2/6] rust: drm: gem: shmem: Add DmaResvGuard helper Lyude Paul
2026-06-04 1:29 ` Claude review: " Claude Code Review Bot
2026-06-03 19:42 ` [PATCH v17 3/6] rust: drm: gem: shmem: Add vmap functions Lyude Paul
2026-06-04 1:29 ` Claude review: " Claude Code Review Bot
2026-06-03 19:42 ` [PATCH v17 4/6] rust: faux: Allow retrieving a bound Device Lyude Paul
2026-06-04 1:29 ` Claude review: " Claude Code Review Bot
2026-06-03 19:42 ` Lyude Paul [this message]
2026-06-04 1:29 ` Claude review: rust: sync: Add SetOnce::reset() Claude Code Review Bot
2026-06-03 19:42 ` [PATCH v17 6/6] rust: drm: gem: Introduce shmem::Object::sg_table() Lyude Paul
2026-06-04 1:29 ` Claude review: " Claude Code Review Bot
2026-06-04 1:29 ` Claude review: Rust bindings for gem shmem Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260603195210.693856-6-lyude@redhat.com \
--to=lyude@redhat.com \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=christian.koenig@amd.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=driver-core@lists.linux.dev \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=lina+kernel@asahilina.net \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mkchauras@gmail.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=sumit.semwal@linaro.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox