public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: rust: faux: Allow retrieving a bound Device
Date: Thu, 04 Jun 2026 11:29:38 +1000	[thread overview]
Message-ID: <review-patch4-20260603195210.693856-5-lyude@redhat.com> (raw)
In-Reply-To: <20260603195210.693856-5-lyude@redhat.com>

Patch Review

**Verdict: Correct, but note the API change.**

```rust
-impl AsRef<device::Device> for Registration {
-    fn as_ref(&self) -> &device::Device {
+impl AsRef<device::Device<device::Bound>> for Registration {
+    fn as_ref(&self) -> &device::Device<device::Bound> {
```

The reasoning is sound -- a `faux::Registration` object is proof that the device is bound, so returning `Device<Bound>` is more precise. The invariant update is appropriate.

**However**, this is a breaking API change. Any existing code that calls `registration.as_ref()` and expects `&device::Device` (with the default context parameter) will break. Since this is in the kernel Rust tree and the faux API is relatively new, this may be acceptable. But it should be confirmed that no other in-tree callers break. The cover letter doesn't mention this.

Also, the old invariant doc used inline text while the new version uses a bullet list -- nice improvement for readability.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-06-04  1:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03 19:42 [PATCH v17 0/6] Rust bindings for gem shmem Lyude Paul
2026-06-03 19:42 ` [PATCH v17 1/6] rust: drm: gem: shmem: Fix Default implementation for ObjectConfig Lyude Paul
2026-06-04  1:29   ` Claude review: " Claude Code Review Bot
2026-06-03 19:42 ` [PATCH v17 2/6] rust: drm: gem: shmem: Add DmaResvGuard helper Lyude Paul
2026-06-04  1:29   ` Claude review: " Claude Code Review Bot
2026-06-03 19:42 ` [PATCH v17 3/6] rust: drm: gem: shmem: Add vmap functions Lyude Paul
2026-06-04  1:29   ` Claude review: " Claude Code Review Bot
2026-06-03 19:42 ` [PATCH v17 4/6] rust: faux: Allow retrieving a bound Device Lyude Paul
2026-06-04  1:29   ` Claude Code Review Bot [this message]
2026-06-03 19:42 ` [PATCH v17 5/6] rust: sync: Add SetOnce::reset() Lyude Paul
2026-06-04  1:29   ` Claude review: " Claude Code Review Bot
2026-06-03 19:42 ` [PATCH v17 6/6] rust: drm: gem: Introduce shmem::Object::sg_table() Lyude Paul
2026-06-04  1:29   ` Claude review: " Claude Code Review Bot
2026-06-04  1:29 ` Claude review: Rust bindings for gem shmem Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-06-04 19:24 [PATCH v18 0/4] " Lyude Paul
2026-06-04 19:24 ` [PATCH v18 3/4] rust: faux: Allow retrieving a bound Device Lyude Paul
2026-06-04 20:03   ` Claude review: " Claude Code Review Bot
2026-06-02 17:24 [PATCH v16 0/6] Rust bindings for gem shmem Lyude Paul
2026-06-02 17:25 ` [PATCH v16 5/6] rust: faux: Allow retrieving a bound Device Lyude Paul
2026-06-04  2:29   ` Claude review: " Claude Code Review Bot
2026-05-29 18:33 [PATCH v15 0/6] Rust bindings for gem shmem Lyude Paul
2026-05-29 18:34 ` [PATCH v15 4/6] rust: faux: Allow retrieving a bound Device Lyude Paul
2026-06-04  6:06   ` Claude review: " Claude Code Review Bot
2026-05-26 21:28 [PATCH v14 0/6] rust: drm: gem: shmem: Add sg_table() function Lyude Paul
2026-05-26 21:28 ` [PATCH v14 1/6] rust: faux: Allow retrieving a bound Device Lyude Paul
2026-05-27  4:05   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260603195210.693856-5-lyude@redhat.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox