From: Icenowy Zheng <zhengxingda@iscas.ac.cn>
To: Frank Binns <frank.binns@imgtec.com>,
Matt Coster <matt.coster@imgtec.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>
Cc: Brendan King <Brendan.King@imgtec.com>,
Danilo Krummrich <dakr@kernel.org>,
Donald Robson <donald.robson@imgtec.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] pvr: acquire vm_ctx->lock before mapping memory to GPU VM
Date: Wed, 22 Apr 2026 01:56:55 +0800 [thread overview]
Message-ID: <3318ac65b5d16875bdee6b79c808290b93a5d23a.camel@iscas.ac.cn> (raw)
In-Reply-To: <20260421175228.1928742-1-zhengxingda@iscas.ac.cn>
Oops, wrong commit title prefix... Wrote too commits for Mesa recently.
Should be drm/imagination: instead.
Will send a replacement patch (and remove an unreachable Cc).
Quite sorry,
Icenowy
在 2026-04-22三的 01:52 +0800，Icenowy Zheng写道：
> The drm gpuvm code doesn't protect find operation against map
> operation,
> and the driver needs to ensure a map operation shouldn't happen when
> a
> find operation is in progress.
>
> As all occurences of drm_gpuva_find*() is already guarded by
> vm_ctx->lock, make pvr_vm_map() to acquire this lock to prevent
> disturbing any find operation.
>
> This fixes occasional NULL deference in drm_gpuva_find*().
>
> Cc: stable@vger.kernel.org
> Fixes: 4bc736f890ce ("drm/imagination: vm: make use of GPUVM's
> drm_exec helper")
> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
next prev parent reply other threads:[~2026-04-21 17:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 17:52 [PATCH] pvr: acquire vm_ctx->lock before mapping memory to GPU VM Icenowy Zheng
2026-04-21 17:56 ` Icenowy Zheng [this message]
2026-04-22 22:14 ` Claude review: " Claude Code Review Bot
2026-04-22 22:14 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3318ac65b5d16875bdee6b79c808290b93a5d23a.camel@iscas.ac.cn \
--to=zhengxingda@iscas.ac.cn \
--cc=Brendan.King@imgtec.com \
--cc=airlied@gmail.com \
--cc=dakr@kernel.org \
--cc=donald.robson@imgtec.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank.binns@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matt.coster@imgtec.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox