From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: pvr: acquire vm_ctx->lock before mapping memory to GPU VM
Date: Thu, 23 Apr 2026 08:14:32 +1000 [thread overview]
Message-ID: <review-overall-20260421175228.1928742-1-zhengxingda@iscas.ac.cn> (raw)
In-Reply-To: <20260421175228.1928742-1-zhengxingda@iscas.ac.cn>
Overall Series Review
Subject: pvr: acquire vm_ctx->lock before mapping memory to GPU VM
Author: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Patches: 2
Reviewed: 2026-04-23T08:14:32.334692
---
This is a single-patch series that adds `vm_ctx->lock` around the `drm_gpuvm_exec_lock()`/`drm_gpuvm_exec_unlock()` + `pvr_vm_bind_op_exec()` sequence in `pvr_vm_map()`. The stated goal — protecting `drm_gpuva_find*()` from concurrent map operations — is reasonable and consistent with the locking pattern already used in `pvr_vm_unmap()` (line 865) and `pvr_vm_unmap_all()` (line 891).
**However, the patch has a critical bug: it double-unlocks `vm_ctx->lock` on the success path.**
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-22 22:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 17:52 [PATCH] pvr: acquire vm_ctx->lock before mapping memory to GPU VM Icenowy Zheng
2026-04-21 17:56 ` Icenowy Zheng
2026-04-22 22:14 ` Claude review: " Claude Code Review Bot
2026-04-22 22:14 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260421175228.1928742-1-zhengxingda@iscas.ac.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox