From: Neil Armstrong <neil.armstrong@linaro.org>
To: Christian Van <cvan20191@gmail.com>,
Jagan Teki <jagan@amarulasolutions.com>
Cc: Jessica Zhang <jesszhan0024@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panel: feiyang-fy07024di26a30d: return display-on error
Date: Mon, 27 Apr 2026 09:43:08 +0200 [thread overview]
Message-ID: <503bdbd2-8a88-4224-8059-23e9e5c599f7@linaro.org> (raw)
In-Reply-To: <20260425053948.117714-1-cvan20191@gmail.com>
On 4/25/26 07:39, Christian Van wrote:
> mipi_dsi_dcs_set_display_on() returns an error code, but feiyang_enable()
> currently ignores it and always reports success.
>
> Return the DCS command result so callers can observe enable failures.
>
> Signed-off-by: Christian Van <cvan20191@gmail.com>
> ---
> drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
> index 4f8d6d8c0..dbdb7e3cb 100644
> --- a/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
> +++ b/drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c
> @@ -98,9 +98,7 @@ static int feiyang_enable(struct drm_panel *panel)
> /* T12 (video & logic signal rise + backlight rise) T12 >= 200ms */
> msleep(200);
>
> - mipi_dsi_dcs_set_display_on(ctx->dsi);
> -
> - return 0;
> + return mipi_dsi_dcs_set_display_on(ctx->dsi);
> }
>
> static int feiyang_disable(struct drm_panel *panel)
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Thanks,
Neil
next prev parent reply other threads:[~2026-04-27 7:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-25 5:39 [PATCH] drm/panel: feiyang-fy07024di26a30d: return display-on error Christian Van
2026-04-27 7:43 ` Neil Armstrong [this message]
2026-04-28 5:39 ` Claude review: " Claude Code Review Bot
2026-04-28 5:39 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503bdbd2-8a88-4224-8059-23e9e5c599f7@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=cvan20191@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@amarulasolutions.com \
--cc=jesszhan0024@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox