public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panel: feiyang-fy07024di26a30d: return display-on error
Date: Tue, 28 Apr 2026 15:39:46 +1000	[thread overview]
Message-ID: <review-patch1-20260425053948.117714-1-cvan20191@gmail.com> (raw)
In-Reply-To: <20260425053948.117714-1-cvan20191@gmail.com>

Patch Review

**Correctness: Good.**

The original code:
```c
mipi_dsi_dcs_set_display_on(ctx->dsi);

return 0;
```
discards the return value from `mipi_dsi_dcs_set_display_on()`, unconditionally returning success. The replacement:
```c
return mipi_dsi_dcs_set_display_on(ctx->dsi);
```
correctly propagates any error to the caller.

**Consistency with the rest of the driver: Good.** The sibling function `feiyang_disable()` at line 110 already does exactly this pattern with `mipi_dsi_dcs_set_display_off()`:
```c
static int feiyang_disable(struct drm_panel *panel)
{
	struct feiyang *ctx = panel_to_feiyang(panel);

	return mipi_dsi_dcs_set_display_off(ctx->dsi);
}
```
So this patch makes `_enable` consistent with `_disable`.

**Minor observation (not blocking):** The `feiyang_unprepare()` function (line 113) takes a different approach — it checks the return value of `mipi_dsi_dcs_set_display_off()` and logs an error with `dev_err()` before continuing. One could argue that logging the error in `feiyang_enable()` before returning it would aid debugging, but the `_disable` function doesn't log either, so the patch as written is consistent with the existing pattern for the enable/disable pair. This is a style choice and not something that should block acceptance.

**Reviewed-by worthy.** No issues found.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-28  5:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-25  5:39 [PATCH] drm/panel: feiyang-fy07024di26a30d: return display-on error Christian Van
2026-04-27  7:43 ` Neil Armstrong
2026-04-28  5:39 ` Claude Code Review Bot [this message]
2026-04-28  5:39 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260425053948.117714-1-cvan20191@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox