[PATCH] drm/color-mgmt: Typo s/R332/RGB332/

[PATCH] drm/color-mgmt: Typo s/R332/RGB332/

[Geert Uytterhoeven]

Fix a typo of "RGB332" in kerneldoc for the drm_crtc_fill_palette_332()
helper.

Fixes: 7ff61177b7116825 ("drm/color-mgmt: Prepare for RGB332 palettes")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/gpu/drm/drm_color_mgmt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c
index c598b99673fc1515..e7db4e4ea700fe11 100644
--- a/drivers/gpu/drm/drm_color_mgmt.c
+++ b/drivers/gpu/drm/drm_color_mgmt.c
@@ -831,7 +831,7 @@ static void fill_palette_332(struct drm_crtc *crtc, u16 r, u16 g, u16 b,
 }
 
 /**
- * drm_crtc_fill_palette_332 - Programs a default palette for R332-like formats
+ * drm_crtc_fill_palette_332 - Programs a default palette for RGB332-like formats
  * @crtc: The displaying CRTC
  * @set_palette: Callback for programming the hardware gamma LUT
  *
-- 
2.43.0

Re: [PATCH] drm/color-mgmt: Typo s/R332/RGB332/

[Javier Martinez Canillas]

Geert Uytterhoeven <geert+renesas@glider.be> writes:

Hello Geert,

> Fix a typo of "RGB332" in kerneldoc for the drm_crtc_fill_palette_332()
> helper.
>
> Fixes: 7ff61177b7116825 ("drm/color-mgmt: Prepare for RGB332 palettes")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/gpu/drm/drm_color_mgmt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c
> index c598b99673fc1515..e7db4e4ea700fe11 100644
> --- a/drivers/gpu/drm/drm_color_mgmt.c
> +++ b/drivers/gpu/drm/drm_color_mgmt.c
> @@ -831,7 +831,7 @@ static void fill_palette_332(struct drm_crtc *crtc, u16 r, u16 g, u16 b,
>  }
>  
>  /**
> - * drm_crtc_fill_palette_332 - Programs a default palette for R332-like formats
> + * drm_crtc_fill_palette_332 - Programs a default palette for RGB332-like formats
>   * @crtc: The displaying CRTC
>   * @set_palette: Callback for programming the hardware gamma LUT
>   *

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat

Re: [PATCH] drm/color-mgmt: Typo s/R332/RGB332/

[Thomas Zimmermann]

Am 21.04.26 um 09:48 schrieb Geert Uytterhoeven:
> Fix a typo of "RGB332" in kerneldoc for the drm_crtc_fill_palette_332()
> helper.
>
> Fixes: 7ff61177b7116825 ("drm/color-mgmt: Prepare for RGB332 palettes")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   drivers/gpu/drm/drm_color_mgmt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_color_mgmt.c b/drivers/gpu/drm/drm_color_mgmt.c
> index c598b99673fc1515..e7db4e4ea700fe11 100644
> --- a/drivers/gpu/drm/drm_color_mgmt.c
> +++ b/drivers/gpu/drm/drm_color_mgmt.c
> @@ -831,7 +831,7 @@ static void fill_palette_332(struct drm_crtc *crtc, u16 r, u16 g, u16 b,
>   }
>   
>   /**
> - * drm_crtc_fill_palette_332 - Programs a default palette for R332-like formats
> + * drm_crtc_fill_palette_332 - Programs a default palette for RGB332-like formats
>    * @crtc: The displaying CRTC
>    * @set_palette: Callback for programming the hardware gamma LUT
>    *

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)

Claude review: drm/color-mgmt: Typo s/R332/RGB332/

[Claude Code Review Bot]

Overall Series Review

Subject: drm/color-mgmt: Typo s/R332/RGB332/
Author: Geert Uytterhoeven <geert+renesas@glider.be>
Patches: 3
Reviewed: 2026-04-23T08:43:29.667982

---

This is a single trivial patch that fixes a typo in a kerneldoc comment: "R332" should be "RGB332" in the one-line summary of `drm_crtc_fill_palette_332()`. The fix is correct and obviously safe. The commit message is well-formed with a proper `Fixes:` tag referencing the commit that introduced the typo.

**Verdict: Patch looks good. No issues found.**

---
Generated by Claude Code Patch Reviewer

Claude review: drm/color-mgmt: Typo s/R332/RGB332/

[Claude Code Review Bot]

Patch Review

**Status: Reviewed-by worthy**

The change is a one-character fix in a kerneldoc comment:

```
- * drm_crtc_fill_palette_332 - Programs a default palette for R332-like formats
+ * drm_crtc_fill_palette_332 - Programs a default palette for RGB332-like formats
```

The typo is clearly unintentional — the description body on line 838 already correctly says "Programs an RGB332 palette to hardware", and the function name itself references "332" (the RGB332 pixel format where R=3 bits, G=3 bits, B=2 bits). "R332" would imply a single red channel with 332... something, which doesn't make sense.

The `Fixes:` tag correctly points to commit `7ff61177b7116825` ("drm/color-mgmt: Prepare for RGB332 palettes") which introduced the typo.

No concerns with this patch.

---
Generated by Claude Code Patch Reviewer