public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javierm@redhat.com>
To: Brajesh Gupta <Brajesh.Gupta@imgtec.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "tzimmermann@suse.de" <tzimmermann@suse.de>,
	Matt Coster <Matt.Coster@imgtec.com>,
	"simona@ffwll.ch" <simona@ffwll.ch>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"airlied@gmail.com" <airlied@gmail.com>,
	Frank Binns <Frank.Binns@imgtec.com>,
	"maarten.lankhorst@linux.intel.com"
	<maarten.lankhorst@linux.intel.com>,
	"mripard@kernel.org" <mripard@kernel.org>
Subject: Re: [EXTERNAL] [PATCH] drm/imagination: Fix missing pvr_power_fw_{en,dis}able() argument
Date: Wed, 20 May 2026 11:00:55 +0200	[thread overview]
Message-ID: <87zf1uwj3s.fsf@ocarina.mail-host-address-is-not-set> (raw)
In-Reply-To: <5b44cf26b7aae3a35db54492e9c093a3b3fd9342.camel@imgtec.com>

Brajesh Gupta <Brajesh.Gupta@imgtec.com> writes:

> On Tue, 2026-05-19 at 15:12 +0200, Javier Martinez Canillas wrote:

[...]

>>  	if (READ_ONCE(pvr_dev->fw_dev.initialised)) {
>> -		err = pvr_power_fw_enable(pvr_dev);
>> +		err = pvr_power_fw_enable(pvr_dev, true);
>>  		if (err)
>>  			goto err_power_off;
>>  	}
>
> Reviewed-by: Brajesh Gupta <brajesh.gupta@imgtec.com>

Pushed to drm-misc (drm-misc-next). Thanks!

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat


  reply	other threads:[~2026-05-20  9:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 13:12 [PATCH] drm/imagination: Fix missing pvr_power_fw_{en, dis}able() argument Javier Martinez Canillas
2026-05-19 15:10 ` [EXTERNAL] [PATCH] drm/imagination: Fix missing pvr_power_fw_{en,dis}able() argument Brajesh Gupta
2026-05-20  9:00   ` Javier Martinez Canillas [this message]
2026-05-25 12:55 ` Claude review: drm/imagination: Fix missing pvr_power_fw_{en, dis}able() argument Claude Code Review Bot
2026-05-25 12:55 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zf1uwj3s.fsf@ocarina.mail-host-address-is-not-set \
    --to=javierm@redhat.com \
    --cc=Brajesh.Gupta@imgtec.com \
    --cc=Frank.Binns@imgtec.com \
    --cc=Matt.Coster@imgtec.com \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox