public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/imagination: Fix missing pvr_power_fw_{en, dis}able() argument
Date: Mon, 25 May 2026 22:55:10 +1000	[thread overview]
Message-ID: <review-patch1-20260519131239.1291732-1-javierm@redhat.com> (raw)
In-Reply-To: <20260519131239.1291732-1-javierm@redhat.com>

Patch Review

**Correctness: Good.**

The two changes match the function signatures exactly:

1. `pvr_power_fw_disable(pvr_dev, false, true)` — adds the missing `rpm_suspend` parameter. Passing `true` is correct because `pvr_power_device_suspend()` is the system PM suspend path and needs the IRQ disabled (lines 109-112 of `pvr_power.c` show `rpm_suspend=true` calls `disable_irq()`). The `false` for `hard_reset` is also correct — a suspend is not a hard reset.

2. `pvr_power_fw_enable(pvr_dev, true)` — adds the missing `rpm_resume` parameter. Passing `true` is correct because `pvr_power_device_resume()` is the system PM resume path and needs the IRQ re-enabled (line 126-127 show `rpm_resume=true` calls `enable_irq()`).

These values are consistent with the existing (pre-regression) code in the drm-next tree, where the same calls at lines 382 and 412 already have the correct arguments.

**Commit message: Good.** Includes the compiler error output, the `Fixes:` tag pointing to the offending commit, and the `base-commit` / `branch` metadata.

**No issues found.** Reviewed-by would be appropriate here.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-25 12:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 13:12 [PATCH] drm/imagination: Fix missing pvr_power_fw_{en, dis}able() argument Javier Martinez Canillas
2026-05-19 15:10 ` [EXTERNAL] [PATCH] drm/imagination: Fix missing pvr_power_fw_{en,dis}able() argument Brajesh Gupta
2026-05-20  9:00   ` Javier Martinez Canillas
2026-05-25 12:55 ` Claude Code Review Bot [this message]
2026-05-25 12:55 ` Claude review: drm/imagination: Fix missing pvr_power_fw_{en, dis}able() argument Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-19 13:11 [PATCH] " Javier Martinez Canillas
2026-05-25 12:56 ` Claude review: " Claude Code Review Bot
2026-05-25 12:56 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260519131239.1291732-1-javierm@redhat.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox