public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/imagination: Fix missing pvr_power_fw_{en, dis}able() argument
Date: Mon, 25 May 2026 22:56:24 +1000	[thread overview]
Message-ID: <review-patch1-20260519131150.1290393-1-javierm@redhat.com> (raw)
In-Reply-To: <20260519131150.1290393-1-javierm@redhat.com>

Patch Review

**Correctness: Good.** The fix adds the missing arguments with the correct values:

1. **`pvr_power_fw_disable(pvr_dev, false, true)`** — The third argument `rpm_suspend=true` is correct for the device suspend path. When `rpm_suspend` is true, the function calls `disable_irq(pvr_dev->irq)` (line 111 in pvr_power.c), which is the right thing to do during system suspend. This is consistent with the non-suspend caller at line 548 which passes `rpm_suspend=false` (that's the reset path, where IRQ management is handled differently).

2. **`pvr_power_fw_enable(pvr_dev, true)`** — The argument `rpm_resume=true` is correct for the device resume path. When `rpm_resume` is true, the function calls `enable_irq(pvr_dev->irq)` (line 127), re-enabling the IRQ that was disabled during suspend. Again consistent with the reset caller at line 571 which passes `false`.

**Commit message: Good.** Includes the full build error output, clearly identifies the offending commit, and has a proper `Fixes:` tag.

**Minor note:** The drm-next tree I checked already has the correct arguments at these call sites but still uses `fw_dev.booted` rather than `fw_dev.initialised`, suggesting the broken commit 42577ba79fbf hasn't landed there yet (or this fix was already folded in via a different route). The patch's `base-commit` and `branch: drm-misc-next` confirm it targets the tree where the breakage exists.

No issues found. This is a clean, obvious build fix.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25 12:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19 13:11 [PATCH] drm/imagination: Fix missing pvr_power_fw_{en, dis}able() argument Javier Martinez Canillas
2026-05-25 12:56 ` Claude Code Review Bot [this message]
2026-05-25 12:56 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-19 13:12 [PATCH] " Javier Martinez Canillas
2026-05-25 12:55 ` Claude review: " Claude Code Review Bot
2026-05-25 12:55 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260519131150.1290393-1-javierm@redhat.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox