[PATCH] drm/panel: fix kernel-doc warning for devm_drm_panel_add()

[PATCH] drm/panel: fix kernel-doc warning for devm_drm_panel_add()

[Dongyang Jin]

Use the correct kernel-doc notation for struct members to eliminate
kernel-doc warnings:

Warning: drivers/gpu/drm/drm_panel.c:119 function parameter 'dev'
 not described in 'devm_drm_panel_add'
Warning: drivers/gpu/drm/drm_panel.c:119 function parameter 'dev'
 not described in 'devm_drm_panel_add'

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202605210648.RI4ufD66-lkp@intel.com/
Signed-off-by: Dongyang Jin <jindongyang@kylinos.cn>
---
 drivers/gpu/drm/drm_panel.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c
index 04f4a31ed27a..2c5649e433df 100644
--- a/drivers/gpu/drm/drm_panel.c
+++ b/drivers/gpu/drm/drm_panel.c
@@ -108,6 +108,7 @@ static void drm_panel_add_release(void *data)
 
 /**
  * devm_drm_panel_add - add a panel to the global registry using devres
+ * @dev: device to which the panel is attached
  * @panel: panel to add
  *
  * Add a panel to the global registry so that it can be looked
-- 
2.25.1

Re: [PATCH] drm/panel: fix kernel-doc warning for devm_drm_panel_add()

[neil.armstrong]

On 5/21/26 11:45, Dongyang Jin wrote:
> Use the correct kernel-doc notation for struct members to eliminate
> kernel-doc warnings:
> 
> Warning: drivers/gpu/drm/drm_panel.c:119 function parameter 'dev'
>   not described in 'devm_drm_panel_add'
> Warning: drivers/gpu/drm/drm_panel.c:119 function parameter 'dev'
>   not described in 'devm_drm_panel_add'
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202605210648.RI4ufD66-lkp@intel.com/
> Signed-off-by: Dongyang Jin <jindongyang@kylinos.cn>
> ---
>   drivers/gpu/drm/drm_panel.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c
> index 04f4a31ed27a..2c5649e433df 100644
> --- a/drivers/gpu/drm/drm_panel.c
> +++ b/drivers/gpu/drm/drm_panel.c
> @@ -108,6 +108,7 @@ static void drm_panel_add_release(void *data)
>   
>   /**
>    * devm_drm_panel_add - add a panel to the global registry using devres
> + * @dev: device to which the panel is attached
>    * @panel: panel to add
>    *
>    * Add a panel to the global registry so that it can be looked

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil

Claude review: Re: [PATCH] drm/panel: fix kernel-doc warning for devm_drm_panel_add()

[Claude Code Review Bot]

Overall Series Review

Subject: Re: [PATCH] drm/panel: fix kernel-doc warning for devm_drm_panel_add()
Author: neil.armstrong@linaro.org
Patches: 2
Reviewed: 2026-05-25T20:23:36.369912

---

This is a single, trivial documentation-only patch that adds a missing `@dev` kernel-doc parameter description for `devm_drm_panel_add()`. The fix is correct and straightforward.

The function at line 119 clearly takes `struct device *dev` as its first parameter, but the kernel-doc comment block only documented `@panel`. This omission causes the kernel-doc warning reported by the kernel test robot. The patch adds the missing `@dev` line in the correct position (before `@panel`, matching parameter order).

**Verdict: Looks good.** No concerns.

---
Generated by Claude Code Patch Reviewer

Claude review: Re: [PATCH] drm/panel: fix kernel-doc warning for devm_drm_panel_add()

[Claude Code Review Bot]

Patch Review

**Status: Clean**

The patch adds a single line to the kernel-doc comment:

```c
 /**
  * devm_drm_panel_add - add a panel to the global registry using devres
+ * @dev: device to which the panel is attached
  * @panel: panel to add
```

This correctly documents the `struct device *dev` parameter of `devm_drm_panel_add()` at line 119, matching the actual function signature:

```c
int devm_drm_panel_add(struct device *dev, struct drm_panel *panel)
```

- The `@dev` entry is placed before `@panel`, matching the function's parameter order — correct kernel-doc convention.
- The description "device to which the panel is attached" is accurate — `dev` is passed to `devm_add_action_or_reset()` to tie the devres lifecycle to that device.
- The `Reported-by` / `Closes` tags properly reference the kernel test robot report.

No issues found. This is a minimal, correct fix for the reported warning.

---
Generated by Claude Code Patch Reviewer