public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: 肖润宇 <220255722@seu.edu.cn>
To: Christian König <christian.koenig@amd.com>
Cc: alexander.deucher@amd.com, airlied@gmail.com, simona@ffwll.ch,
	kenneth.feng@amd.com, kevinyang.wang@amd.com,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, jianhao.xu@seu.edu.cn,
	stable@vger.kernel.org
Subject: Re:Re: [PATCH 1/2] drm/amdgpu/mes11: fix queue init wptr reset
Date: Tue, 2 Jun 2026 18:53:03 +0800 (GMT+08:00)	[thread overview]
Message-ID: <AMgAqgBUKT9GR95Sm49u6arg.3.1780397583210.Hmail.220255722@seu.edu.cn> (raw)
In-Reply-To: <bb4e417d-5669-4d06-a731-c9aa369f6bd7@amd.com>

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

Hi Christian,


Thanks, understood.


To make sure I rework this in the right direction: would you expect
this reset path to do


  ring->wptr = 0;
  amdgpu_ring_set_wptr(ring);


instead of writing wptr_cpu_addr directly?


I am asking because amdgpu_ring_set_wptr() also updates the doorbell,
so I want to confirm that this is the intended sequence for the
reset/suspend case here.


Thanks,
Runyu


On Tue, Jun 2, 2026 at 11:49:05AM +0200, Christian König wrote:
> Clear NAK.
>
> The atomic64_t cast hack is just something we did for older
> generations and is not something which is necessary nor should
> be done here.
>
> What could be possible is that we need to use amdgpu_ring_set_wptr()
> here to correctly distinguish between queues with 32bit and 64bit
> wptrs.


[-- Attachment #2: Type: text/html, Size: 3510 bytes --]

  reply	other threads:[~2026-06-02 22:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02  5:03 [PATCH 0/2] drm/amdgpu: fix MES queue init wptr reset on atomic64 carriers Runyu Xiao
2026-06-02  5:03 ` [PATCH 1/2] drm/amdgpu/mes11: fix queue init wptr reset Runyu Xiao
2026-06-02  9:49   ` Christian König
2026-06-02 10:53     ` 肖润宇 [this message]
2026-06-02 11:19       ` Christian König
2026-06-02 12:03         ` Runyu Xiao
2026-06-03  9:00         ` Runyu Xiao
2026-06-04  3:17   ` Claude review: " Claude Code Review Bot
2026-06-02  5:03 ` [PATCH 2/2] drm/amdgpu/mes12: " Runyu Xiao
2026-06-04  3:17   ` Claude review: " Claude Code Review Bot
2026-06-04  3:17 ` Claude review: drm/amdgpu: fix MES queue init wptr reset on atomic64 carriers Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AMgAqgBUKT9GR95Sm49u6arg.3.1780397583210.Hmail.220255722@seu.edu.cn \
    --to=220255722@seu.edu.cn \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jianhao.xu@seu.edu.cn \
    --cc=kenneth.feng@amd.com \
    --cc=kevinyang.wang@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=simona@ffwll.ch \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox