public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: 杨孙运 <yangsunyun1993@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: syyang@lontium.com, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, andrzej.hajda@intel.com,
	neil.armstrong@linaro.org, dmitry.baryshkov@oss.qualcomm.com,
	maarten.lankhorst@linux.intel.com, rfoss@kernel.org,
	mripard@kernel.org, Laurent.pinchart@ideasonboard.com,
	tzimmermann@suse.de, jonas@kwiboo.se, jernej.skrabec@gmail.com,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	xmzhu@lontium.corp-partner.google.com, xmzhu@lontium.com,
	rlyu@lontium.com, xbpeng@lontium.com
Subject: Re: [PATCH v3 1/2] dt-bindings:bridge: Add Lontiun LT7911EXC eDP to MIPI DSI bridge
Date: Thu, 30 Apr 2026 16:43:41 +0800	[thread overview]
Message-ID: <CAFQXuNZ-+0dKFrViisWG4NK=yk2zJ5tn21RZZ3ze7ctsV6Ruew@mail.gmail.com> (raw)
In-Reply-To: <20260430-gainful-hopping-quokka-da7e7b@quoll>

Krzysztof Kozlowski <krzk@kernel.org> 于2026年4月30日周四 15:56写道:
>
> On Wed, Apr 29, 2026 at 12:05:40PM +0800, syyang@lontium.com wrote:
> > From: Sunyun Yang <syyang@lontium.com>
> >
> > The LT7911EXC is an I2C-controlled bridge that Receiver eDP1.4
> > and output signal/dual port mipi.
> >
> > Signed-off-by: Sunyun Yang <syyang@lontium.com>
>
> Missing space after ':' in subject.
>
it will be fixed in next version.
> ...
>
> > +  ports:
> > +    $ref: /schemas/graph.yaml#/properties/ports
> > +
> > +    properties:
> > +      port@0:
> > +        $ref: /schemas/graph.yaml#/properties/port
> > +        description: Video port for MIPI DSI output.
>
> Wrong description, first is input. Look at your DTS.
>
yes, you are right, I didn't notice this place.

it will be fixed in next version.
thanks Krzysztof Kozlowski

> > +
> > +      port@1:
> > +        $ref: /schemas/graph.yaml#/properties/port
> > +        description: Video port for eDP input.
> > +
> > +    required:
> > +      - port@0
> > +      - port@1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - reset-gpios
> > +  - vdd-supply
> > +  - vcc-supply
> > +  - ports
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        mipi-bridge@41 {
> > +            compatible = "lontium,lt7911exc";
> > +            reg = <0x41>;
> > +            reset-gpios = <&gpy8 8 GPIO_ACTIVE_LOW>;
> > +            vdd-supply = <&lt7911exc_1v2>;
> > +            vcc-supply = <&lt7911exc_3v3>;
> > +
> > +            ports {
> > +                #address-cells = <1>;
> > +                #size-cells = <0>;
> > +
> > +                port@0 {
> > +                    reg = <0>;
> > +                    bridge_in: endpoint {
> > +                        remote-endpoint = <&edp_out>;
> > +                    };
> > +                };
>
> Best regards,
> Krzysztof
>

  reply	other threads:[~2026-04-30 17:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29  4:05 [PATCH v3 0/2] Add Lontiun LT7911EXC eDP to MIPI DSI bridge syyang
2026-04-29  4:05 ` [PATCH v3 1/2] dt-bindings:bridge: " syyang
2026-04-30  7:56   ` Krzysztof Kozlowski
2026-04-30  8:43     ` 杨孙运 [this message]
2026-04-30  8:55       ` 杨孙运
2026-05-05  1:58   ` Claude review: " Claude Code Review Bot
2026-04-29  4:05 ` [PATCH v3 2/2] drm:bridge: " syyang
2026-05-05  1:58   ` Claude review: " Claude Code Review Bot
2026-05-05  1:58 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFQXuNZ-+0dKFrViisWG4NK=yk2zJ5tn21RZZ3ze7ctsV6Ruew@mail.gmail.com' \
    --to=yangsunyun1993@gmail.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=andrzej.hajda@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=rlyu@lontium.com \
    --cc=robh@kernel.org \
    --cc=syyang@lontium.com \
    --cc=tzimmermann@suse.de \
    --cc=xbpeng@lontium.com \
    --cc=xmzhu@lontium.com \
    --cc=xmzhu@lontium.corp-partner.google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox