public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings:bridge: Add Lontiun LT7911EXC eDP to MIPI DSI bridge
Date: Tue, 05 May 2026 11:58:22 +1000	[thread overview]
Message-ID: <review-patch1-20260429040541.3404116-2-syyang@lontium.com> (raw)
In-Reply-To: <20260429040541.3404116-2-syyang@lontium.com>

Patch Review

**Port descriptions are swapped.** The binding declares:
```yaml
port@0:
  description: Video port for MIPI DSI output.
port@1:
  description: Video port for eDP input.
```

But the example has:
```yaml
port@0:
  bridge_in: endpoint {
    remote-endpoint = <&edp_out>;
  };
port@1:
  bridge_out: endpoint {
    remote-endpoint = <&panel_in>;
  };
```

The endpoint label `bridge_in` connecting to `edp_out` at port@0 indicates port@0 is the eDP **input**, and `bridge_out` connecting to `panel_in` at port@1 indicates port@1 is the MIPI DSI **output**. The driver confirms this — it calls `devm_drm_of_get_bridge(dev, dev->of_node, 1, 0)` on port@1 to get the downstream (output) bridge. The descriptions for port@0 and port@1 should be swapped.

**Missing `description` at the top level** of the schema (under `title:`). While not strictly required, it is conventional.

**Typo in the series subject**: "Lontiun" should be "Lontium" (appears in subject line and cover letter).

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-05  1:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29  4:05 [PATCH v3 0/2] Add Lontiun LT7911EXC eDP to MIPI DSI bridge syyang
2026-04-29  4:05 ` [PATCH v3 1/2] dt-bindings:bridge: " syyang
2026-04-30  7:56   ` Krzysztof Kozlowski
2026-04-30  8:43     ` 杨孙运
2026-04-30  8:55       ` 杨孙运
2026-05-05  1:58   ` Claude Code Review Bot [this message]
2026-04-29  4:05 ` [PATCH v3 2/2] drm:bridge: " syyang
2026-05-05  1:58   ` Claude review: " Claude Code Review Bot
2026-05-05  1:58 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260429040541.3404116-2-syyang@lontium.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox