public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Enchanted Hunter <enchantedredhunter@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	andy@kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] staging: fbtft: replace sprintf with snprintf
Date: Tue, 2 Jun 2026 21:31:56 +0300	[thread overview]
Message-ID: <CAHp75VdtOuLEkiuiUqxa3DT75y8Hd-1PtquodpN4qJ=rCFs_4Q@mail.gmail.com> (raw)
In-Reply-To: <CAOSULedF6GUK_e_3KRPB+D0Jxgtow38OjQu9B1=vG-XTfsdYOA@mail.gmail.com>

On Tue, Jun 2, 2026 at 8:13 PM Enchanted Hunter
<enchantedredhunter@gmail.com> wrote:
>
> Overall, it doesn't address any compiler warnings, but this is my first patch. I wanted to start with something concrete, and I saw an unsafe function and tried to fix it. The fact that the compilation behavior won't change is true, but the code will become a bit more formal — maybe that's a good thing.

Not sure we need a churn on the working code.

A process hint: Do not top-post.

> пн, 1 июн. 2026 г. в 11:25, Andy Shevchenko <andy.shevchenko@gmail.com>:
>>
>> On Mon, Jun 1, 2026 at 3:44 AM Enchanted Hunter
>> <enchantedredhunter@gmail.com> wrote:
>> >
>> > This patch replaces unsafe sprintf calls with snprintf in
>> > fbtft_register_framebuffer() to prevent potential buffer overflow.
>> >
>> > Signed-off-by: rat1bor <enchantedredhunter@gmail.com>

Another thing, use your real name and not an alias.

>> Does this change address any compiler warning or something like that?
>> At a glance I do not see any usefulness of this patch except an
>> unneeded churn.

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2026-06-02 18:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01  0:43 [PATCH] staging: fbtft: replace sprintf with snprintf Enchanted Hunter
2026-06-01  5:44 ` Greg KH
2026-06-04  4:40   ` Claude review: " Claude Code Review Bot
2026-06-04  4:40   ` Claude Code Review Bot
2026-06-01  8:25 ` Andy Shevchenko
2026-06-02 17:12   ` Enchanted Hunter
2026-06-02 18:31     ` Andy Shevchenko [this message]
2026-06-02 19:33       ` Enchanted Hunter
2026-06-03  1:13         ` Andy Shevchenko
2026-06-03  9:14           ` Enchanted Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75VdtOuLEkiuiUqxa3DT75y8Hd-1PtquodpN4qJ=rCFs_4Q@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=andy@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=enchantedredhunter@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox