Claude review: Re: [PATCH] staging: fbtft: replace sprintf with snprintf

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Re: [PATCH] staging: fbtft: replace sprintf with snprintf
Author: Greg KH <gregkh@linuxfoundation.org>
Patches: 8
Reviewed: 2026-06-04T14:40:17.699184

---

This is a single-patch submission that replaces `sprintf` with `snprintf` in `fbtft_register_framebuffer()` in the staging fbtft driver. The change is functionally correct but has several submission quality issues that would likely result in the patch being rejected in its current form.

**Submission issues:**
1. The patch was sent as a **base64-encoded MIME attachment** rather than inline in the email body. Kernel patches must be sent inline per `Documentation/process/submitting-patches.rst`. Tools like `git send-email` should be used.
2. The **commit message has no body** — the Signed-off-by immediately follows the subject. The cover letter text ("This patch replaces unsafe sprintf calls...") should be the commit message body, not just in the email.
3. The **From name** in the email ("Enchanted Hunter") doesn't match the **Signed-off-by name** ("rat1bor"). The kernel requires a real name for contributions; pseudonyms are generally not accepted.
4. The commit message in the cover letter body has formatting errors: "infbtft_register_framebuffer()" (missing space after "in") and "overflow.Signed-off-by" (missing newline before the tag).

---
Generated by Claude Code Patch Reviewer