RE: [PATCH] drm/buddy: Integrate lockdep annotations for gpu buddy manager

["Upadhyay, Tejas" <tejas.upadhyay@intel.com>]

> -----Original Message-----
> From: Auld, Matthew <matthew.auld@intel.com>
> Sent: 30 April 2026 14:45
> To: Upadhyay, Tejas <tejas.upadhyay@intel.com>; intel-
> xe@lists.freedesktop.org
> Cc: Arunpravin.PaneerSelvam@amd.com; dri-devel@lists.freedesktop.org;
> amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/buddy: Integrate lockdep annotations for gpu
> buddy manager
> 
> On 29/04/2026 13:37, Tejas Upadhyay wrote:
> > gpu_buddy APIs are expected to be called with the driver-provided lock
> > held, but there is no runtime enforcement of this contract. Add
> > lockdep annotations to catch locking violations early.
> >
> > Introduce gpu_buddy_driver_set_lock() for the driver to register the
> > lock that protects the buddy manager. Add gpu_buddy_driver_lock_held()
> > assertions to all exported gpu_buddy and drm_buddy APIs that
> > access/modify the manager state. The lock_dep_map field is only
> > compiled in when CONFIG_LOCKDEP is enabled, adding zero overhead to
> > production builds.
> >
> > Wire up xe_ttm_vram_mgr to register its mutex with the buddy manager
> > after initialization.
> >
> > Assisted-by: Claude:claude-opus-4.6
> 
> I think add:
> 
> Suggested-by: Matthew Brost <matthew.brost@intel.com>

Sure thanks for review, will add.

Tejas
> 
> > Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
> 
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>