From: "Upadhyay, Tejas" <tejas.upadhyay@intel.com>
To: "Auld, Matthew" <matthew.auld@intel.com>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>
Cc: "Arunpravin.PaneerSelvam@amd.com"
<Arunpravin.PaneerSelvam@amd.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Subject: RE: [PATCH] drm/buddy: Integrate lockdep annotations for gpu buddy manager
Date: Thu, 30 Apr 2026 13:12:54 +0000 [thread overview]
Message-ID: <SN6PR11MB3232A69655EB743710B6C9FE81352@SN6PR11MB3232.namprd11.prod.outlook.com> (raw)
In-Reply-To: <4dea1e78-da81-4c5b-ab8d-62d6f99e4889@intel.com>
Failures isn’t related to change https://patchwork.freedesktop.org/series/165720/#rev1. Will merge it later. Please let me know in case of any concerns.
Tejas
> -----Original Message-----
> From: Auld, Matthew <matthew.auld@intel.com>
> Sent: 30 April 2026 14:45
> To: Upadhyay, Tejas <tejas.upadhyay@intel.com>; intel-
> xe@lists.freedesktop.org
> Cc: Arunpravin.PaneerSelvam@amd.com; dri-devel@lists.freedesktop.org;
> amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/buddy: Integrate lockdep annotations for gpu
> buddy manager
>
> On 29/04/2026 13:37, Tejas Upadhyay wrote:
> > gpu_buddy APIs are expected to be called with the driver-provided lock
> > held, but there is no runtime enforcement of this contract. Add
> > lockdep annotations to catch locking violations early.
> >
> > Introduce gpu_buddy_driver_set_lock() for the driver to register the
> > lock that protects the buddy manager. Add gpu_buddy_driver_lock_held()
> > assertions to all exported gpu_buddy and drm_buddy APIs that
> > access/modify the manager state. The lock_dep_map field is only
> > compiled in when CONFIG_LOCKDEP is enabled, adding zero overhead to
> > production builds.
> >
> > Wire up xe_ttm_vram_mgr to register its mutex with the buddy manager
> > after initialization.
> >
> > Assisted-by: Claude:claude-opus-4.6
>
> I think add:
>
> Suggested-by: Matthew Brost <matthew.brost@intel.com>
>
> > Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
>
> Reviewed-by: Matthew Auld <matthew.auld@intel.com>
next prev parent reply other threads:[~2026-04-30 13:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 12:37 [PATCH] drm/buddy: Integrate lockdep annotations for gpu buddy manager Tejas Upadhyay
2026-04-30 9:14 ` Matthew Auld
2026-04-30 9:34 ` Upadhyay, Tejas
2026-04-30 13:12 ` Upadhyay, Tejas [this message]
2026-05-05 1:39 ` Claude review: " Claude Code Review Bot
2026-05-05 1:39 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB3232A69655EB743710B6C9FE81352@SN6PR11MB3232.namprd11.prod.outlook.com \
--to=tejas.upadhyay@intel.com \
--cc=Arunpravin.PaneerSelvam@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox