From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Louis Chauvet <louis.chauvet@bootlin.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
Melissa Wen <melissa.srw@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
dri-devel@lists.freedesktop.org
Subject: [PATCH] drm/vkms: Constify struct configfs_item_operations and configfs_group_operations
Date: Mon, 25 May 2026 14:30:56 +0200 [thread overview]
Message-ID: <ade89ec366460754dd1746dd8001afb53cfaffbf.1779712234.git.christophe.jaillet@wanadoo.fr> (raw)
'struct configfs_item_operations' and 'configfs_group_operations' are not
modified in this driver.
Constifying these structures moves some data to a read-only section, so
increases overall security, especially when the structure holds some
function pointers.
On a x86_64, with allmodconfig, as an example:
Before:
======
text data bss dec hex filename
21554 10096 128 31778 7c22 drivers/gpu/drm/vkms/vkms_configfs.o
After:
=====
text data bss dec hex filename
22546 9104 128 31778 7c22 drivers/gpu/drm/vkms/vkms_configfs.o
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only.
---
drivers/gpu/drm/vkms/vkms_configfs.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/vkms/vkms_configfs.c b/drivers/gpu/drm/vkms/vkms_configfs.c
index 7551b8c7766d..b2b3343f9d35 100644
--- a/drivers/gpu/drm/vkms/vkms_configfs.c
+++ b/drivers/gpu/drm/vkms/vkms_configfs.c
@@ -189,7 +189,7 @@ static void crtc_release(struct config_item *item)
}
}
-static struct configfs_item_operations crtc_item_operations = {
+static const struct configfs_item_operations crtc_item_operations = {
.release = &crtc_release,
};
@@ -231,7 +231,7 @@ static struct config_group *make_crtc_group(struct config_group *group,
return &crtc->group;
}
-static struct configfs_group_operations crtcs_group_operations = {
+static const struct configfs_group_operations crtcs_group_operations = {
.make_group = &make_crtc_group,
};
@@ -276,7 +276,7 @@ static void plane_possible_crtcs_drop_link(struct config_item *src,
vkms_config_plane_detach_crtc(plane->config, crtc->config);
}
-static struct configfs_item_operations plane_possible_crtcs_item_operations = {
+static const struct configfs_item_operations plane_possible_crtcs_item_operations = {
.allow_link = plane_possible_crtcs_allow_link,
.drop_link = plane_possible_crtcs_drop_link,
};
@@ -345,7 +345,7 @@ static void plane_release(struct config_item *item)
}
}
-static struct configfs_item_operations plane_item_operations = {
+static const struct configfs_item_operations plane_item_operations = {
.release = &plane_release,
};
@@ -393,7 +393,7 @@ static struct config_group *make_plane_group(struct config_group *group,
return &plane->group;
}
-static struct configfs_group_operations planes_group_operations = {
+static const struct configfs_group_operations planes_group_operations = {
.make_group = &make_plane_group,
};
@@ -438,7 +438,7 @@ static void encoder_possible_crtcs_drop_link(struct config_item *src,
vkms_config_encoder_detach_crtc(encoder->config, crtc->config);
}
-static struct configfs_item_operations encoder_possible_crtcs_item_operations = {
+static const struct configfs_item_operations encoder_possible_crtcs_item_operations = {
.allow_link = encoder_possible_crtcs_allow_link,
.drop_link = encoder_possible_crtcs_drop_link,
};
@@ -462,7 +462,7 @@ static void encoder_release(struct config_item *item)
}
}
-static struct configfs_item_operations encoder_item_operations = {
+static const struct configfs_item_operations encoder_item_operations = {
.release = &encoder_release,
};
@@ -510,7 +510,7 @@ static struct config_group *make_encoder_group(struct config_group *group,
return &encoder->group;
}
-static struct configfs_group_operations encoders_group_operations = {
+static const struct configfs_group_operations encoders_group_operations = {
.make_group = &make_encoder_group,
};
@@ -579,7 +579,7 @@ static void connector_release(struct config_item *item)
}
}
-static struct configfs_item_operations connector_item_operations = {
+static const struct configfs_item_operations connector_item_operations = {
.release = &connector_release,
};
@@ -628,7 +628,7 @@ static void connector_possible_encoders_drop_link(struct config_item *src,
}
}
-static struct configfs_item_operations connector_possible_encoders_item_operations = {
+static const struct configfs_item_operations connector_possible_encoders_item_operations = {
.allow_link = connector_possible_encoders_allow_link,
.drop_link = connector_possible_encoders_drop_link,
};
@@ -677,7 +677,7 @@ static struct config_group *make_connector_group(struct config_group *group,
return &connector->group;
}
-static struct configfs_group_operations connectors_group_operations = {
+static const struct configfs_group_operations connectors_group_operations = {
.make_group = &make_connector_group,
};
@@ -750,7 +750,7 @@ static void device_release(struct config_item *item)
kfree(dev);
}
-static struct configfs_item_operations device_item_operations = {
+static const struct configfs_item_operations device_item_operations = {
.release = &device_release,
};
@@ -802,7 +802,7 @@ static struct config_group *make_device_group(struct config_group *group,
return &dev->group;
}
-static struct configfs_group_operations device_group_ops = {
+static const struct configfs_group_operations device_group_ops = {
.make_group = &make_device_group,
};
--
2.54.0
next reply other threads:[~2026-05-25 12:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 12:30 Christophe JAILLET [this message]
2026-05-25 21:16 ` Claude review: drm/vkms: Constify struct configfs_item_operations and configfs_group_operations Claude Code Review Bot
2026-05-25 21:16 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ade89ec366460754dd1746dd8001afb53cfaffbf.1779712234.git.christophe.jaillet@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.chauvet@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=melissa.srw@gmail.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox