public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Christian König <christian.koenig@amd.com>
To: Randy Dunlap <rdunlap@infradead.org>, dri-devel@lists.freedesktop.org
Cc: Sumit Semwal <sumit.semwal@linaro.org>, linux-media@vger.kernel.org
Subject: Re: [PATCH] dma-fence: correct kernel-doc function parameter @flags
Date: Tue, 7 Apr 2026 09:59:23 +0200	[thread overview]
Message-ID: <cbc66e2d-6195-4c8a-a86e-335c459db1c0@amd.com> (raw)
In-Reply-To: <20260407043649.2015894-1-rdunlap@infradead.org>

On 4/7/26 06:36, Randy Dunlap wrote:
> 'make htmldocs' complains that dma_fence_unlock_irqrestore() is missing
> a description of its @flags parameter. The description is there but it is
> missing a ':' sign. Add that and correct the possessive form of "its".
> 
> WARNING: ../include/linux/dma-fence.h:414 function parameter 'flags' not described in 'dma_fence_unlock_irqrestore'
> 
> Fixes: 3e5067931b5d ("dma-buf: abstract fence locking v2")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>

Reviewed-by: Christian König <christian.koenig@amd.com>

Going to push it later today.

> ---
> Cc: Christian König <christian.koenig@amd.com>
> Cc: Sumit Semwal <sumit.semwal@linaro.org>
> Cc: linux-media@vger.kernel.org
> 
>  include/linux/dma-fence.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-next-20260406.orig/include/linux/dma-fence.h
> +++ linux-next-20260406/include/linux/dma-fence.h
> @@ -408,9 +408,9 @@ static inline spinlock_t *dma_fence_spin
>  /**
>   * dma_fence_unlock_irqrestore - unlock the fence and irqrestore
>   * @fence: the fence to unlock
> - * @flags the CPU flags to restore
> + * @flags: the CPU flags to restore
>   *
> - * Unlock the fence, allowing it to change it's state to signaled again.
> + * Unlock the fence, allowing it to change its state to signaled again.
>   */
>  #define dma_fence_unlock_irqrestore(fence, flags)	\
>  	spin_unlock_irqrestore(dma_fence_spinlock(fence), flags)


  reply	other threads:[~2026-04-07  7:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07  4:36 [PATCH] dma-fence: correct kernel-doc function parameter @flags Randy Dunlap
2026-04-07  7:59 ` Christian König [this message]
2026-04-12  4:05 ` Claude review: " Claude Code Review Bot
2026-04-12  4:05 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cbc66e2d-6195-4c8a-a86e-335c459db1c0@amd.com \
    --to=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-media@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox