public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-fence: correct kernel-doc function parameter @flags
Date: Sun, 12 Apr 2026 14:05:33 +1000	[thread overview]
Message-ID: <review-patch1-20260407043649.2015894-1-rdunlap@infradead.org> (raw)
In-Reply-To: <20260407043649.2015894-1-rdunlap@infradead.org>

Patch Review

**Status: Correct but already applied**

The patch makes two changes:

1. **Missing colon in kernel-doc `@flags` tag:**
```diff
- * @flags the CPU flags to restore
+ * @flags: the CPU flags to restore
```
This is a valid fix. Kernel-doc requires the `@param:` format with a colon; without it, `make htmldocs` emits the warning cited in the commit message.

2. **Grammar fix — "it's" → "its":**
```diff
- * Unlock the fence, allowing it to change it's state to signaled again.
+ * Unlock the fence, allowing it to change its state to signaled again.
```
Correct — "its" (possessive) is right here, not "it's" (contraction of "it is").

**Observations:**
- The `Fixes:` tag references `3e5067931b5d ("dma-buf: abstract fence locking v2")` which is the commit that introduced the doc comment with the typos. Appropriate.
- The patch is against `linux-next-20260406` (visible from the `---`/`+++` paths). The drm-next tree already contains both fixes at lines 411 and 413, so this patch has already been merged or an equivalent fix was applied independently.
- The diff context, line numbers, and surrounding code all check out.
- Appropriate Cc list (Christian König as dma-buf/dma-fence maintainer, Sumit Semwal, linux-media).

**Verdict:** The patch is correct in both substance and form, but is a no-op against current drm-next since the fix is already present. If reviewing against the original base where the typos still exist, this is a clean **Reviewed-by**-worthy patch.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-12  4:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07  4:36 [PATCH] dma-fence: correct kernel-doc function parameter @flags Randy Dunlap
2026-04-07  7:59 ` Christian König
2026-04-12  4:05 ` Claude Code Review Bot [this message]
2026-04-12  4:05 ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260407043649.2015894-1-rdunlap@infradead.org \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox