From: Damon Ding <damon.ding@rock-chips.com>
To: Luca Ceresoli <luca.ceresoli@bootlin.com>,
Ethan Tidmore <ethantidmore06@gmail.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Heiko Stuebner <heiko@sntech.de>,
Marek Szyprowski <m.szyprowski@samsung.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/bridge: analogix_dp: Extract error pointer from correct variable
Date: Thu, 30 Apr 2026 09:08:03 +0800 [thread overview]
Message-ID: <fecd104d-4d2c-434e-92c9-21a1dcbb51d4@rock-chips.com> (raw)
In-Reply-To: <DI5LR1VCMTKO.1S3KLBK8F0XIA@bootlin.com>
On 4/29/2026 7:29 PM, Luca Ceresoli wrote:
> On Wed Apr 29, 2026 at 5:08 AM CEST, Ethan Tidmore wrote:
>> In devm_drm_panel_bridge_add() error path the pointer error should be
>> extracted from dp->plat_data->next_bridge but instead it is extracted
>> from bridge, which is a valid pointer and not part of this error path.
>>
>> Extract error pointer from correct variable.
>>
>> Detected by Smatch:
>> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1489 analogix_dp_bind()
>> warn: passing a valid pointer to 'PTR_ERR'
>>
>> Fixes: 1b86a69b61df4 ("drm/bridge: analogix_dp: Apply panel_bridge helper")
>> Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
>
Reviewed-by: Damon Ding <damon.ding@rock-chips.com>
Best regards,
Damon
next prev parent reply other threads:[~2026-04-30 1:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 3:08 [PATCH] drm/bridge: analogix_dp: Extract error pointer from correct variable Ethan Tidmore
2026-04-29 11:29 ` Luca Ceresoli
2026-04-30 1:08 ` Damon Ding [this message]
2026-05-04 7:02 ` Luca Ceresoli
2026-05-05 1:59 ` Claude review: " Claude Code Review Bot
2026-05-05 1:59 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fecd104d-4d2c-434e-92c9-21a1dcbb51d4@rock-chips.com \
--to=damon.ding@rock-chips.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ethantidmore06@gmail.com \
--cc=heiko@sntech.de \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox