public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: analogix_dp: Extract error pointer from correct variable
Date: Tue, 05 May 2026 11:59:49 +1000	[thread overview]
Message-ID: <review-patch1-20260429030840.704252-1-ethantidmore06@gmail.com> (raw)
In-Reply-To: <20260429030840.704252-1-ethantidmore06@gmail.com>

Patch Review

**Bug Analysis**: Correct and real bug. The code does:
```c
dp->plat_data->next_bridge = devm_drm_panel_bridge_add(dp->dev,
                                                       dp->plat_data->panel);
if (IS_ERR(dp->plat_data->next_bridge)) {
    ret = PTR_ERR(bridge);  // BUG: wrong variable
    goto err_unregister_aux;
}
```

`bridge` is a separate local variable (the `struct drm_bridge *` for `dp->bridge`) that is a valid pointer at this point. Calling `PTR_ERR()` on a valid pointer returns garbage — typically a large positive number that gets truncated to an `int`, resulting in a misleading or zero return code. The caller would not see a proper `-ENODEV`/`-ENOMEM`/etc.

**Fix**: Correct. Changes `PTR_ERR(bridge)` to `PTR_ERR(dp->plat_data->next_bridge)`, matching the variable tested by `IS_ERR()`.

```c
ret = PTR_ERR(dp->plat_data->next_bridge);  // FIXED: matches IS_ERR check
```

**Commit message**: Clear and well-structured. Includes the Smatch warning, a proper `Fixes:` tag referencing the commit that introduced the bug (`1b86a69b61df4`), and a signed-off-by.

**Minor notes**:
- The `Fixes:` tag hash `1b86a69b61df4` uses 13 hex chars — the standard convention is 12 chars. This is cosmetic and most tooling handles it fine, but `1b86a69b61df` would be more conventional.
- As noted above, this code has been removed in drm-next. The maintainers should consider whether this patch should target stable branches instead.

**Rating**: The fix is correct, minimal, and addresses a genuine bug. Recommended for merge (targeting the appropriate branch where this code still exists).

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-05-05  1:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29  3:08 [PATCH] drm/bridge: analogix_dp: Extract error pointer from correct variable Ethan Tidmore
2026-04-29 11:29 ` Luca Ceresoli
2026-04-30  1:08   ` Damon Ding
2026-05-04  7:02 ` Luca Ceresoli
2026-05-05  1:59 ` Claude review: " Claude Code Review Bot
2026-05-05  1:59 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260429030840.704252-1-ethantidmore06@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox