From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
Cc: srini@kernel.org, linux-arm-msm@vger.kernel.org,
gregkh@linuxfoundation.org, quic_bkumar@quicinc.com,
linux-kernel@vger.kernel.org, quic_chennak@quicinc.com,
dri-devel@lists.freedesktop.org, arnd@arndb.de,
ltuikov89@gmail.com, konrad.dybcio@oss.qualcomm.com,
andersson@kernel.org
Subject: Re: [PATCH v9 4/4] misc: fastrpc: Add polling mode support for fastRPC driver
Date: Wed, 22 Apr 2026 18:47:19 +0300 [thread overview]
Message-ID: <jqehwyeoda5t5kabxjouc4kgpnebndotkr2a4tuuiypzqcck42@dv3vu7wbq6nh> (raw)
In-Reply-To: <20260422092409.4107093-5-ekansh.gupta@oss.qualcomm.com>
On Wed, Apr 22, 2026 at 02:54:09PM +0530, Ekansh Gupta wrote:
> For any remote call to DSP, after sending an invocation message,
> fastRPC driver waits for glink response and during this time the
> CPU can go into low power modes. This adds latency to overall fastrpc
> call as CPU wakeup and scheduling latencies are included. Add polling
> mode support with which fastRPC driver will poll continuously on a
> memory after sending a message to remote subsystem which will eliminate
> CPU wakeup and scheduling latencies and reduce fastRPC overhead. In case
> poll timeout happens, the call will fallback to normal RPC mode. Poll
> mode can be enabled by user by using FASTRPC_IOCTL_SET_OPTION ioctl
> request with FASTRPC_POLL_MODE request id.
>
> Signed-off-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
> ---
> drivers/misc/fastrpc.c | 148 ++++++++++++++++++++++++++++++++++--
> include/uapi/misc/fastrpc.h | 25 ++++++
> 2 files changed, 166 insertions(+), 7 deletions(-)
>
> @@ -2331,6 +2446,22 @@ static const struct fastrpc_soc_data default_soc_data = {
> .dma_addr_bits_default = 32,
> };
>
> +/*
> + * Older platforms that use default_soc_data but whose DSP firmware
> + * supports the FastRPC polling mode.
There should be a comment, "don't add more platforms to this list".
> + */
> +static const struct of_device_id fastrpc_poll_supported_machines[] __maybe_unused = {
> + { .compatible = "qcom,qcs8300" },
> + { .compatible = "qcom,qcs9100" },
Use qcom,sa8775p instead. See sa8775p-ride boards.
What about qcom,sar2130p?
qcom,sc8280xp?
qcom,milos?
> + { .compatible = "qcom,sm8450" },
> + { .compatible = "qcom,sm8550" },
> + { .compatible = "qcom,sm8650" },
> + { .compatible = "qcom,sm8750" },
> + { .compatible = "qcom,x1e80100" },
> + { .compatible = "qcom,x1p42100" },
> + {},
> +};
> +
> static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev)
> {
> struct device *rdev = &rpdev->dev;
--
With best wishes
Dmitry
next prev parent reply other threads:[~2026-04-22 15:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 9:24 [PATCH v9 0/4] misc: fastrpc: Add polling mode support Ekansh Gupta
2026-04-22 9:24 ` [PATCH v9 1/4] misc: fastrpc: Move fdlist to invoke context structure Ekansh Gupta
2026-04-22 15:48 ` Dmitry Baryshkov
2026-04-22 21:50 ` Claude review: " Claude Code Review Bot
2026-04-22 9:24 ` [PATCH v9 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Ekansh Gupta
2026-04-22 15:47 ` Dmitry Baryshkov
2026-04-22 21:50 ` Claude review: " Claude Code Review Bot
2026-04-22 9:24 ` [PATCH v9 3/4] misc: fastrpc: Expand context ID mask for DSP polling mode support Ekansh Gupta
2026-04-22 21:50 ` Claude review: " Claude Code Review Bot
2026-04-22 9:24 ` [PATCH v9 4/4] misc: fastrpc: Add polling mode support for fastRPC driver Ekansh Gupta
2026-04-22 15:47 ` Dmitry Baryshkov [this message]
2026-04-22 21:50 ` Claude review: " Claude Code Review Bot
2026-04-22 21:50 ` Claude review: misc: fastrpc: Add polling mode support Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jqehwyeoda5t5kabxjouc4kgpnebndotkr2a4tuuiypzqcck42@dv3vu7wbq6nh \
--to=dmitry.baryshkov@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=ekansh.gupta@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ltuikov89@gmail.com \
--cc=quic_bkumar@quicinc.com \
--cc=quic_chennak@quicinc.com \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox