public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
Cc: srini@kernel.org, linux-arm-msm@vger.kernel.org,
	gregkh@linuxfoundation.org, quic_bkumar@quicinc.com,
	linux-kernel@vger.kernel.org, quic_chennak@quicinc.com,
	dri-devel@lists.freedesktop.org, arnd@arndb.de,
	ltuikov89@gmail.com, konrad.dybcio@oss.qualcomm.com,
	andersson@kernel.org
Subject: Re: [PATCH v9 1/4] misc: fastrpc: Move fdlist to invoke context structure
Date: Wed, 22 Apr 2026 18:48:02 +0300	[thread overview]
Message-ID: <wlohwqmz6iflmxkkbv25z4xwa5jv4xgxjbwvckiyunnysea3hr@fwjl3ueblrw7> (raw)
In-Reply-To: <20260422092409.4107093-2-ekansh.gupta@oss.qualcomm.com>

On Wed, Apr 22, 2026 at 02:54:06PM +0530, Ekansh Gupta wrote:
> The fdlist is currently part of the meta buffer which is set during
> fastrpc_get_args(), this fdlist is getting recalculated during
> fastrpc_put_args().
> 
> Move fdlist to the invoke context structure to improve maintainability
> and reduce redundancy. This centralizes its handling and simplifies
> meta buffer preparation and reading logic.
> 
> Signed-off-by: Ekansh Gupta <ekansh.gupta@oss.qualcomm.com>
> ---
>  drivers/misc/fastrpc.c | 13 ++++---------
>  1 file changed, 4 insertions(+), 9 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

  reply	other threads:[~2026-04-22 15:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22  9:24 [PATCH v9 0/4] misc: fastrpc: Add polling mode support Ekansh Gupta
2026-04-22  9:24 ` [PATCH v9 1/4] misc: fastrpc: Move fdlist to invoke context structure Ekansh Gupta
2026-04-22 15:48   ` Dmitry Baryshkov [this message]
2026-04-22 21:50   ` Claude review: " Claude Code Review Bot
2026-04-22  9:24 ` [PATCH v9 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Ekansh Gupta
2026-04-22 15:47   ` Dmitry Baryshkov
2026-04-22 21:50   ` Claude review: " Claude Code Review Bot
2026-04-22  9:24 ` [PATCH v9 3/4] misc: fastrpc: Expand context ID mask for DSP polling mode support Ekansh Gupta
2026-04-22 21:50   ` Claude review: " Claude Code Review Bot
2026-04-22  9:24 ` [PATCH v9 4/4] misc: fastrpc: Add polling mode support for fastRPC driver Ekansh Gupta
2026-04-22 15:47   ` Dmitry Baryshkov
2026-04-22 21:50   ` Claude review: " Claude Code Review Bot
2026-04-22 21:50 ` Claude review: misc: fastrpc: Add polling mode support Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wlohwqmz6iflmxkkbv25z4xwa5jv4xgxjbwvckiyunnysea3hr@fwjl3ueblrw7 \
    --to=dmitry.baryshkov@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=arnd@arndb.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ekansh.gupta@oss.qualcomm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltuikov89@gmail.com \
    --cc=quic_bkumar@quicinc.com \
    --cc=quic_chennak@quicinc.com \
    --cc=srini@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox