From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: backlight: ktd2801: enable BL_CORE_SUSPENDRESUME
Date: Tue, 31 Mar 2026 17:51:56 +1000 [thread overview]
Message-ID: <review-overall-20260328-ktd2801-pm-fix-v1-1-007cb103faeb@dujemihanovic.xyz> (raw)
In-Reply-To: <20260328-ktd2801-pm-fix-v1-1-007cb103faeb@dujemihanovic.xyz>
Overall Series Review
Subject: backlight: ktd2801: enable BL_CORE_SUSPENDRESUME
Author: =?utf-8?q?Duje_Mihanovi=C4=87?= <dujemihanovic32@gmail.com>
Patches: 1
Reviewed: 2026-03-31T17:51:56.057017
---
This is a single-patch series that adds `BL_CORE_SUSPENDRESUME` to the KTD2801 backlight driver's ops. The fix is straightforward, correct, and well-motivated. The backlight core's suspend/resume handling will call `update_status` with brightness=0 on suspend and restore brightness on resume, which is the standard mechanism for backlight power management. The driver's `ktd2801_update_status` already handles the blank/unblank transitions correctly via `expresswire_power_off` / `expresswire_enable`, so this flag is all that's needed.
**Verdict: Looks good.** This is a minimal, correct fix.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 7:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 20:42 [PATCH] backlight: ktd2801: enable BL_CORE_SUSPENDRESUME Duje Mihanović
2026-03-31 7:51 ` Claude Code Review Bot [this message]
2026-03-31 7:51 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260328-ktd2801-pm-fix-v1-1-007cb103faeb@dujemihanovic.xyz \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox