public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: backlight: ktd2801: enable BL_CORE_SUSPENDRESUME
Date: Tue, 31 Mar 2026 17:51:56 +1000	[thread overview]
Message-ID: <review-patch1-20260328-ktd2801-pm-fix-v1-1-007cb103faeb@dujemihanovic.xyz> (raw)
In-Reply-To: <20260328-ktd2801-pm-fix-v1-1-007cb103faeb@dujemihanovic.xyz>

Patch Review

**Status: Good to merge**

The change adds a single line to `ktd2801_backlight_ops`:

```c
static const struct backlight_ops ktd2801_backlight_ops = {
	.options = BL_CORE_SUSPENDRESUME,
	.update_status = ktd2801_update_status,
};
```

This is the standard pattern used by many other backlight drivers (e.g., `pwm_bl`, `lp855x`, `gpio_backlight`, etc.) to have the backlight core handle suspend/resume automatically. When this flag is set, the core calls `backlight_suspend()` / `backlight_resume()` which sets `fb_blank` to `FB_BLANK_POWERDOWN` on suspend and restores it on resume, triggering `update_status`.

The existing `ktd2801_update_status` already handles this correctly:
- `backlight_is_blank()` returning true triggers `expresswire_power_off()` (line 40)
- On resume, `expresswire_enable()` is called followed by the brightness write (lines 46-50)

The `was_on` tracking (lines 41, 45-48) ensures the enable/disable sequencing is correct across suspend/resume cycles.

The `Cc: stable@vger.kernel.org # v6.19` tag is appropriate since this is a bug fix for a driver introduced in that version.

No issues found.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-03-31  7:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-28 20:42 [PATCH] backlight: ktd2801: enable BL_CORE_SUSPENDRESUME Duje Mihanović
2026-03-31  7:51 ` Claude review: " Claude Code Review Bot
2026-03-31  7:51 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260328-ktd2801-pm-fix-v1-1-007cb103faeb@dujemihanovic.xyz \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox