From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: bridge: ldb: Require reg property only for i.MX6SX/8MP LDBs
Date: Tue, 31 Mar 2026 17:49:51 +1000 [thread overview]
Message-ID: <review-overall-20260329-fsl_ldb_schema_fix-v1-1-351372754bc0@nxp.com> (raw)
In-Reply-To: <20260329-fsl_ldb_schema_fix-v1-1-351372754bc0@nxp.com>
Overall Series Review
Subject: dt-bindings: display: bridge: ldb: Require reg property only for i.MX6SX/8MP LDBs
Author: Liu Ying <victor.liu@nxp.com>
Patches: 8
Reviewed: 2026-03-31T17:49:51.247576
---
This is a single-patch fix to the `fsl,ldb.yaml` dt-bindings schema. The problem is real: the i.MX93 LDB is a child of a syscon (Media blk-ctrl) that doesn't allow `reg` properties in its children, but the schema currently requires `reg` globally for all LDB variants. The fix correctly makes `reg` (and `reg-names`) conditional on the specific compatible strings that need them.
The patch is logically sound and the approach of using per-compatible `if/then` blocks is the standard dt-bindings pattern for this kind of differentiation. **No significant issues found.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 7:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-29 7:51 [PATCH] dt-bindings: display: bridge: ldb: Require reg property only for i.MX6SX/8MP LDBs Liu Ying
2026-03-29 17:42 ` Marco Felsch
2026-03-29 18:29 ` Marek Vasut
2026-03-30 6:29 ` Marco Felsch
2026-03-30 23:22 ` Marek Vasut
2026-03-30 2:05 ` Liu Ying
2026-03-30 10:28 ` Marco Felsch
2026-03-31 2:01 ` Liu Ying
2026-03-31 7:49 ` Claude Code Review Bot [this message]
2026-03-31 7:49 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260329-fsl_ldb_schema_fix-v1-1-351372754bc0@nxp.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox