From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm: default separate_gpu_kms to auto selection
Date: Tue, 31 Mar 2026 17:21:55 +1000 [thread overview]
Message-ID: <review-overall-20260330-separate_gpu_kms-v3-1-a3e54b9c9417@oss.qualcomm.com> (raw)
In-Reply-To: <20260330-separate_gpu_kms-v3-1-a3e54b9c9417@oss.qualcomm.com>
Overall Series Review
Subject: drm/msm: default separate_gpu_kms to auto selection
Author: Mahadevan P <mahadevan.p@oss.qualcomm.com>
Patches: 1
Reviewed: 2026-03-31T17:21:55.073456
---
This is a single patch (v3) that changes the `separate_gpu_kms` module parameter from a boolean to a tristate (`-1`/`0`/`1`), adding an auto-detection mode that counts GPUs and display subsystems to decide whether to bind them together or expose them as separate DRM devices. The motivation is clear: platforms like SA8775P with multiple display subsystems need them to probe independently.
The design is reasonable and the auto-detection logic is sound. However, there is a **device node reference leak** that must be fixed before this can be merged, and a few minor points worth addressing.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 7:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 9:52 [PATCH v3] drm/msm: default separate_gpu_kms to auto selection Mahadevan P
2026-03-31 7:21 ` Claude Code Review Bot [this message]
2026-03-31 7:21 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260330-separate_gpu_kms-v3-1-a3e54b9c9417@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox