Claude review: drm/amdgpu: fix locking issues in PASID IDR management

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/amdgpu: fix locking issues in PASID IDR management
Author: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
Patches: 3
Reviewed: 2026-03-31T17:36:41.530736

---

This is a well-structured 2-patch series fixing two real locking bugs introduced by commit `14b81abe7bdc` / `8f1de51f49be` ("drm/amdgpu: prevent immediate PASID reuse case"), which converted PASID allocation from IDA to IDR with a spinlock.

The two bugs are:
1. **Sleeping under spinlock**: `idr_alloc_cyclic()` called with `GFP_KERNEL` inside `spin_lock()`.
2. **IRQ deadlock**: `amdgpu_pasid_free()` reachable from hardirq context (fence signal path) but the lock taken with plain `spin_lock()` in process context.

Both fixes use well-established kernel patterns. The patches are correctly ordered (patch 1 is a prerequisite for patch 2, as patch 2 builds on the code introduced by patch 1). The cover letter is excellent with clear problem description, call chain, and test details.

**Verdict: Series looks correct and ready to apply.** One minor nit on patch 2 below.

---

---
Generated by Claude Code Patch Reviewer