From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/panthor: Add a GEM shrinker
Date: Tue, 31 Mar 2026 17:24:45 +1000 [thread overview]
Message-ID: <review-overall-20260330094848.2169422-1-boris.brezillon@collabora.com> (raw)
In-Reply-To: <20260330094848.2169422-1-boris.brezillon@collabora.com>
Overall Series Review
Subject: drm/panthor: Add a GEM shrinker
Author: Boris Brezillon <boris.brezillon@collabora.com>
Patches: 11
Reviewed: 2026-03-31T17:24:45.257645
---
This is a well-structured 9-patch series adding GEM shrinker support to the panthor GPU driver. The series is at v6 and has already collected Reviewed-by from both Steven Price and Liviu Dudau on all patches. The approach is sound: first fork away from `drm_gem_shmem_object` to gain control over page lifetimes (patch 5), add lazy page allocation on mmap (patch 6), prepare the infrastructure (patches 7-8), then implement the shrinker itself (patch 9). The preparatory patches (1-4) are clean and low-risk.
The locking strategy (trylock everywhere in the reclaim path) is pragmatic given the lock ordering constraints. The tiered LRU approach (unused -> mmapped -> single-VM GPU mapped -> multi-VM GPU mapped) is reasonable. The series has clearly benefited from multiple review rounds and addresses prior concerns well.
A few items are worth attention, mostly in the large patch 9.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-31 7:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 9:48 [PATCH v6 0/9] drm/panthor: Add a GEM shrinker Boris Brezillon
2026-03-30 9:48 ` [PATCH v6 1/9] drm/gem: Consider GEM object reclaimable if shrinking fails Boris Brezillon
2026-03-31 7:24 ` Claude review: " Claude Code Review Bot
2026-03-30 9:48 ` [PATCH v6 2/9] drm/panthor: Move panthor_gems_debugfs_init() to panthor_gem.c Boris Brezillon
2026-03-31 7:24 ` Claude review: " Claude Code Review Bot
2026-03-30 9:48 ` [PATCH v6 3/9] drm/panthor: Group panthor_kernel_bo_xxx() helpers Boris Brezillon
2026-03-31 7:24 ` Claude review: " Claude Code Review Bot
2026-03-30 9:48 ` [PATCH v6 4/9] drm/panthor: Don't call drm_gpuvm_bo_extobj_add() if the object is private Boris Brezillon
2026-03-31 7:24 ` Claude review: " Claude Code Review Bot
2026-03-30 9:48 ` [PATCH v6 5/9] drm/panthor: Part ways with drm_gem_shmem_object Boris Brezillon
2026-03-31 7:24 ` Claude review: " Claude Code Review Bot
2026-03-30 9:48 ` [PATCH v6 6/9] drm/panthor: Lazily allocate pages on mmap() Boris Brezillon
2026-03-31 7:24 ` Claude review: " Claude Code Review Bot
2026-03-30 9:48 ` [PATCH v6 7/9] drm/panthor: Split panthor_vm_prepare_map_op_ctx() to prepare for reclaim Boris Brezillon
2026-03-31 7:24 ` Claude review: " Claude Code Review Bot
2026-03-30 9:48 ` [PATCH v6 8/9] drm/panthor: Track the number of mmap on a BO Boris Brezillon
2026-03-31 7:24 ` Claude review: " Claude Code Review Bot
2026-03-30 9:48 ` [PATCH v6 9/9] drm/panthor: Add a GEM shrinker Boris Brezillon
2026-03-31 7:24 ` Claude review: " Claude Code Review Bot
2026-03-30 10:39 ` [PATCH v6 0/9] " Steven Price
2026-03-31 7:24 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-09 15:11 [PATCH v5 " Boris Brezillon
2026-03-09 15:11 ` [PATCH v5 9/9] " Boris Brezillon
2026-03-10 2:15 ` Claude review: " Claude Code Review Bot
2026-03-10 2:15 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260330094848.2169422-1-boris.brezillon@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox